Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Side by Side Diff: include/utils/SkJSONCPP.h

Issue 282053002: Generate bench/Android.mk from gyp. (Closed) Base URL: https://skia.googlesource.com/skia.git@baselines
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 * 6 *
7 * A common place to put the jsoncpp library includes, as opposed to littering 7 * A common place to put the jsoncpp library includes, as opposed to littering
8 * the pragmas repeatedly through our code. 8 * the pragmas repeatedly through our code.
9 */ 9 */
10 #ifndef SkJSONCPP_DEFINED 10 #ifndef SkJSONCPP_DEFINED
11 #define SkJSONCPP_DEFINED 11 #define SkJSONCPP_DEFINED
12 12
13 // FIXME (scroggo): JSON is disabled in Android framework until we solve
14 // skbug.com/2448
15 #ifndef SK_BUILD_FOR_ANDROID_FRAMEWORK
16
hal.canary 2014/05/15 14:29:36 Can we just not include this file? #ifdef SK_BUIL
scroggo 2014/05/15 20:00:54 As stated elsewhere, I think it's simpler to inclu
13 #ifdef SK_BUILD_FOR_WIN 17 #ifdef SK_BUILD_FOR_WIN
14 // json includes xlocale which generates warning 4530 because we're 18 // json includes xlocale which generates warning 4530 because we're
15 // compiling without exceptions; 19 // compiling without exceptions;
16 // see https://code.google.com/p/skia/issues/detail?id=1067 20 // see https://code.google.com/p/skia/issues/detail?id=1067
17 #pragma warning(push) 21 #pragma warning(push)
18 #pragma warning(disable : 4530) 22 #pragma warning(disable : 4530)
19 #endif 23 #endif
20 #include "json/reader.h" 24 #include "json/reader.h"
21 #include "json/value.h" 25 #include "json/value.h"
22 #ifdef SK_BUILD_FOR_WIN 26 #ifdef SK_BUILD_FOR_WIN
23 #pragma warning(pop) 27 #pragma warning(pop)
24 #endif 28 #endif
25 29
30 #endif // SK_BUILD_FOR_ANDROID_FRAMEWORK
31
26 #endif 32 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698