Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2820473003: Use file Uri to launch intent for download on M and below (Closed)

Created:
3 years, 8 months ago by qinmin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Use file Uri to launch intent for download on M and below Content Uri has permission issues on certain devices Use file Uri instead. TBR=dtrainor@chromium.org,nyquist@chromium.org BUG=705748 Review-Url: https://codereview.chromium.org/2799533002 Cr-Commit-Position: refs/heads/master@{#463698} (cherry picked from commit ca6e72620f092e950e6ce788bde57455a4e73eb1) Review-Url: https://codereview.chromium.org/2820473003 . Cr-Commit-Position: refs/branch-heads/3029@{#693} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/504d45617e2fe1708455f98a0ad09a764affbd78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -16 lines) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 1 chunk +12 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/FileUtils.java View 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java View 4 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
3 years, 8 months ago (2017-04-13 17:18:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
504d45617e2fe1708455f98a0ad09a764affbd78 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698