Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2820473002: Rename NavigatorCPU mixin to NavigatorConcurrentHardware to match spec (Closed)

Created:
3 years, 8 months ago by foolip
Modified:
3 years, 8 months ago
Reviewers:
domenic, Rick Byers
CC:
blink-reviews, blink-reviews-frames_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, falken+watch_chromium.org, horo+watch_chromium.org, kinuko+worker_chromium.org, shimazu+worker_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename NavigatorCPU mixin to NavigatorConcurrentHardware to match spec The name of a mixin is not observable, so this is refactoring only. This also changes the type to unsigned long long to match the spec, but this will not be observable in any way. BUG=709019 R=domenic@chromium.org Review-Url: https://codereview.chromium.org/2820473002 Cr-Commit-Position: refs/heads/master@{#464913} Committed: https://chromium.googlesource.com/chromium/src/+/4f4d0e4f9122db7ee36d5bbd3b086d998aa9e9c1

Patch Set 1 #

Messages

Total messages: 17 (10 generated)
foolip
3 years, 8 months ago (2017-04-13 07:00:20 UTC) #1
domenic
lgtm
3 years, 8 months ago (2017-04-13 17:17:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820473002/1
3 years, 8 months ago (2017-04-17 06:28:55 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-17 06:28:56 UTC) #10
Rick Byers
RS LGTM
3 years, 8 months ago (2017-04-17 07:50:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820473002/1
3 years, 8 months ago (2017-04-17 07:50:48 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 09:58:14 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f4d0e4f9122db7ee36d5bbd3b08...

Powered by Google App Engine
This is Rietveld 408576698