Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2820443002: ash: Move "CAPS LOCK is on." bubble to the notification center. (Closed)

Created:
3 years, 8 months ago by tetsui2
Modified:
3 years, 8 months ago
Reviewers:
tdanderson, fukino
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Move "CAPS LOCK is on." bubble to the notification center. When caps lock is enabled with Alt+Search, "CAPS LOCK is on." bubble pops up. However, the bubble was not using the notification center. BUG=686203 TEST=manually tested. Review-Url: https://codereview.chromium.org/2820443002 Cr-Commit-Position: refs/heads/master@{#464659} Committed: https://chromium.googlesource.com/chromium/src/+/3f0af475fd6e46a14e6a33cc538e5b24c86ab803

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -43 lines) Patch
M ash/system/system_notifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/system_notifier.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M ash/system/tray_caps_lock.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/tray_caps_lock.cc View 1 7 chunks +35 lines, -36 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
tetsui2
3 years, 8 months ago (2017-04-13 04:54:32 UTC) #2
fukino
Looking good to me. Let me defer to tdanderson@ for an OWNER's review.
3 years, 8 months ago (2017-04-13 07:27:38 UTC) #4
tetsui2
Thank you for reviewing!
3 years, 8 months ago (2017-04-13 07:28:28 UTC) #5
tdanderson
Thanks for doing this! LGTM with a few comments below. https://codereview.chromium.org/2820443002/diff/1/ash/system/tray_caps_lock.cc File ash/system/tray_caps_lock.cc (right): https://codereview.chromium.org/2820443002/diff/1/ash/system/tray_caps_lock.cc#newcode58 ...
3 years, 8 months ago (2017-04-13 17:01:38 UTC) #6
tetsui2
Thank you! https://codereview.chromium.org/2820443002/diff/1/ash/system/tray_caps_lock.cc File ash/system/tray_caps_lock.cc (right): https://codereview.chromium.org/2820443002/diff/1/ash/system/tray_caps_lock.cc#newcode58 ash/system/tray_caps_lock.cc:58: TrayPopupItemStyle::FontStyle::DEFAULT_VIEW_LABEL); On 2017/04/13 17:01:37, tdanderson wrote: > ...
3 years, 8 months ago (2017-04-14 01:54:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820443002/20001
3 years, 8 months ago (2017-04-14 01:56:08 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 02:31:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3f0af475fd6e46a14e6a33cc538e...

Powered by Google App Engine
This is Rietveld 408576698