Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2820423002: Move quic_flags.h from net/quic/core to net/quic/platform and split into api and impl. (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move quic_flags.h from net/quic/core to net/quic/platform and split into api and impl. Merge internal change: 153366836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -159 lines) Patch
M net/BUILD.gn View 3 chunks +3 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/bbr_sender.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/congestion_control/cubic.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/cubic_bytes.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/cubic_bytes_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/cubic_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/send_algorithm_interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_bytes.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_buffered_packet_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_buffered_packet_store_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_client_session_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_connection_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_client_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_data_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_data_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_data_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/quic/core/quic_flags.h View 1 chunk +0 lines, -60 lines 0 comments Download
D net/quic/core/quic_flags.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M net/quic/core/quic_flow_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_framer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_framer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_header_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_header_list_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_headers_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_packet_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_packets.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_sent_packet_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_sent_packet_manager_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_server_session_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_spdy_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_spdy_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_version_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/quic_version_manager_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_versions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_versions_test.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_sequencer_buffer_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/platform/impl/quic_socket_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_packet_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_simple_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/stateless_rejector.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/stateless_rejector_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2825833002 Patch 1

Dependent Patchsets:

Issue 2821263003 Patch 1

Messages

Total messages: 5 (1 generated)
Ryan Hamilton
3 years, 8 months ago (2017-04-18 19:01:50 UTC) #2
Zhongyi Shi
I think you probably forget to add the net/quic/platform/api/quic_flags.* to be committed?
3 years, 8 months ago (2017-04-18 21:54:40 UTC) #3
Ryan Hamilton
On 2017/04/18 21:54:40, Zhongyi Shi wrote: > I think you probably forget to add the ...
3 years, 8 months ago (2017-04-18 22:42:00 UTC) #4
Zhongyi Shi
3 years, 8 months ago (2017-04-18 22:53:23 UTC) #5 
lgtm

Powered by Google App Engine
This is Rietveld 408576698