Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: net/tools/quic/quic_dispatcher_test.cc

Issue 2820423002: Move quic_flags.h from net/quic/core to net/quic/platform and split into api and impl. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_dispatcher.cc ('k') | net/tools/quic/quic_packet_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher_test.cc
diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc
index 46f52c11f743a0c681d2da780916563bd8e9c1c4..3f3f235180e232df8aaf3587cd4ca060aa08ad92 100644
--- a/net/tools/quic/quic_dispatcher_test.cc
+++ b/net/tools/quic/quic_dispatcher_test.cc
@@ -13,8 +13,8 @@
#include "net/quic/core/crypto/quic_crypto_server_config.h"
#include "net/quic/core/crypto/quic_random.h"
#include "net/quic/core/quic_crypto_stream.h"
-#include "net/quic/core/quic_flags.h"
#include "net/quic/core/quic_utils.h"
+#include "net/quic/platform/api/quic_flags.h"
#include "net/quic/platform/api/quic_logging.h"
#include "net/quic/platform/api/quic_str_cat.h"
#include "net/quic/test_tools/crypto_test_utils.h"
@@ -535,7 +535,7 @@ TEST_F(QuicDispatcherTest, SupportedVersionsChangeInFlight) {
static_assert(arraysize(kSupportedQuicVersions) == 5u,
"Supported versions out of sync");
FLAGS_quic_reloadable_flag_quic_enable_version_38 = true;
- base::SetFlag(&FLAGS_quic_enable_version_39, true);
+ SetQuicFlag(&FLAGS_quic_enable_version_39, true);
QuicSocketAddress client_address(QuicIpAddress::Loopback4(), 1);
server_address_ = QuicSocketAddress(QuicIpAddress::Any4(), 5);
QuicConnectionId connection_id = 1;
@@ -575,7 +575,7 @@ TEST_F(QuicDispatcherTest, SupportedVersionsChangeInFlight) {
PACKET_6BYTE_PACKET_NUMBER, 1);
// Turn off version 39.
- base::SetFlag(&FLAGS_quic_enable_version_39, false);
+ SetQuicFlag(&FLAGS_quic_enable_version_39, false);
++connection_id;
EXPECT_CALL(*dispatcher_, CreateQuicSession(connection_id, client_address))
.Times(0);
@@ -584,7 +584,7 @@ TEST_F(QuicDispatcherTest, SupportedVersionsChangeInFlight) {
PACKET_6BYTE_PACKET_NUMBER, 1);
// Turn on version 39.
- base::SetFlag(&FLAGS_quic_enable_version_39, true);
+ SetQuicFlag(&FLAGS_quic_enable_version_39, true);
++connection_id;
EXPECT_CALL(*dispatcher_, CreateQuicSession(connection_id, client_address))
.WillOnce(testing::Return(CreateSession(
« no previous file with comments | « net/tools/quic/quic_dispatcher.cc ('k') | net/tools/quic/quic_packet_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698