Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2820383002: [ObjC ARC] Converts ios/chrome/browser/metrics:metrics_internal to ARC. (Closed)

Created:
3 years, 8 months ago by stkhapugin
Modified:
3 years, 7 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, asvitkine+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/metrics:metrics_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2820383002 Cr-Commit-Position: refs/heads/master@{#469004} Committed: https://chromium.googlesource.com/chromium/src/+/7ad61a7154af4788bcc4d1333698709bf1aa42ac

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove empty line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M ios/chrome/browser/metrics/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/metrics/new_tab_page_uma.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/metrics/size_class_recorder.mm View 1 2 chunks +4 lines, -1 line 0 comments Download
M ios/chrome/browser/metrics/tab_usage_recorder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/metrics/tab_usage_recorder.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
stkhapugin
PTAL
3 years, 8 months ago (2017-04-18 15:36:59 UTC) #4
lpromero
lgtm https://codereview.chromium.org/2820383002/diff/1/ios/chrome/browser/metrics/size_class_recorder.mm File ios/chrome/browser/metrics/size_class_recorder.mm (right): https://codereview.chromium.org/2820383002/diff/1/ios/chrome/browser/metrics/size_class_recorder.mm#newcode96 ios/chrome/browser/metrics/size_class_recorder.mm:96: ; Remove. Weird!
3 years, 8 months ago (2017-04-18 16:22:14 UTC) #7
stkhapugin
Thank you! https://codereview.chromium.org/2820383002/diff/1/ios/chrome/browser/metrics/size_class_recorder.mm File ios/chrome/browser/metrics/size_class_recorder.mm (right): https://codereview.chromium.org/2820383002/diff/1/ios/chrome/browser/metrics/size_class_recorder.mm#newcode96 ios/chrome/browser/metrics/size_class_recorder.mm:96: ; On 2017/04/18 16:22:14, lpromero wrote: > ...
3 years, 7 months ago (2017-05-03 15:27:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820383002/20001
3 years, 7 months ago (2017-05-03 15:28:07 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 16:41:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7ad61a7154af4788bcc4d1333698...

Powered by Google App Engine
This is Rietveld 408576698