Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Issue 2820343003: Disable several flaky mojo localstorage tests on Mac. (Closed)

Created:
3 years, 8 months ago by Marijn Kruisselbrink
Modified:
3 years, 8 months ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable several flaky mojo localstorage tests on Mac. Somehow sometimes browser shutdown crashes on shutting down the DB thread for these tests on mac. BUG=712872 Review-Url: https://codereview.chromium.org/2820343003 Cr-Commit-Position: refs/heads/master@{#465644} Committed: https://chromium.googlesource.com/chromium/src/+/17e49b087759887c2ebe54950ab5efdf45472fee

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M content/browser/dom_storage/dom_storage_browsertest.cc View 1 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
Marijn Kruisselbrink
3 years, 8 months ago (2017-04-18 23:35:02 UTC) #7
michaeln
bah... shutdown'isms... lgtm :(
3 years, 8 months ago (2017-04-19 01:04:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820343003/20001
3 years, 8 months ago (2017-04-19 17:04:34 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 17:09:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/17e49b087759887c2ebe54950ab5...

Powered by Google App Engine
This is Rietveld 408576698