Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2820323003:
Ash: Make window resize shadow extend beneath window it's attached to. (Closed)
|
Created:
3 years, 8 months ago by Evan Stade Modified:
3 years, 8 months ago CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAsh: Make window resize shadow extend beneath window it's attached to.
Gets rid of an empty pixel or two due to the window's rounded corner.
BUG=706364
Review-Url: https://codereview.chromium.org/2820323003
Cr-Commit-Position: refs/heads/master@{#465576}
Committed: https://chromium.googlesource.com/chromium/src/+/a26f514d0a7b98f146782a538c463bc39bfdf773
Patch Set 1 #
Total comments: 2
Messages
Total messages: 19 (12 generated)
estade@chromium.org changed reviewers: + pkotwicz@chromium.org
The CQ bit was checked by estade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Ash: Make window resize shadow extend beneath window it's attached to. Gets rid of an empty pixel or two due to the window's rounded corner. BUG=706364 ========== to ========== Ash: Make window resize shadow extend beneath window it's attached to. Gets rid of an empty pixel or two due to the window's rounded corner. BUG=706364 ==========
pkotwicz@chromium.org changed reviewers: + oshima@chromium.org - pkotwicz@chromium.org
pkotwicz@chromium.org changed reviewers: + pkotwicz@chromium.org
Swapping myself with Oshima
oshima@chromium.org changed reviewers: + varkha@chromium.org
+varkha@. if he can't review soon, i'll review this evening.
Lgtm with an optional suggestion. https://codereview.chromium.org/2820323003/diff/1/ash/wm/resize_shadow.cc File ash/wm/resize_shadow.cc (right): https://codereview.chromium.org/2820323003/diff/1/ash/wm/resize_shadow.cc#new... ash/wm/resize_shadow.cc:23: // the corner radius of the actual window. Should one just be equal to the other, even if you keep both constants for self documenting the code?
https://codereview.chromium.org/2820323003/diff/1/ash/wm/resize_shadow.cc File ash/wm/resize_shadow.cc (right): https://codereview.chromium.org/2820323003/diff/1/ash/wm/resize_shadow.cc#new... ash/wm/resize_shadow.cc:23: // the corner radius of the actual window. On 2017/04/18 22:31:58, varkha wrote: > Should one just be equal to the other, even if you keep both constants for self > documenting the code? Arguably. I actually think it's easier to read like this because it's hard to mess up reading "2" whereas kCornerRadiusOfFoo could require you to read every word carefully.
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492608194991610, "parent_rev":
"649ba8ba12885957013ede4684b0266b4f4d641e", "commit_rev":
"a26f514d0a7b98f146782a538c463bc39bfdf773"}
Message was sent while issue was closed.
Description was changed from ========== Ash: Make window resize shadow extend beneath window it's attached to. Gets rid of an empty pixel or two due to the window's rounded corner. BUG=706364 ========== to ========== Ash: Make window resize shadow extend beneath window it's attached to. Gets rid of an empty pixel or two due to the window's rounded corner. BUG=706364 Review-Url: https://codereview.chromium.org/2820323003 Cr-Commit-Position: refs/heads/master@{#465576} Committed: https://chromium.googlesource.com/chromium/src/+/a26f514d0a7b98f146782a538c46... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a26f514d0a7b98f146782a538c46... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
