Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2820303002: Add a UMA histogram for measuring DetachableResourceHandler duration (Closed)

Created:
3 years, 8 months ago by yhirano
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, Randy Smith (Not in Mondays), darin-cc_chromium.org, asvitkine+watch_chromium.org, loading-reviews_chromium.org, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a UMA histogram for measuring DetachableResourceHandler duration BUG=709910 Review-Url: https://codereview.chromium.org/2820303002 Cr-Commit-Position: refs/heads/master@{#465171} Committed: https://chromium.googlesource.com/chromium/src/+/56866c20d1252bb4ad9a6a0ed51a14fa73b7632f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/browser/loader/detachable_resource_handler.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
yhirano
I think measuring the duration is enough - or do you want the completion status ...
3 years, 8 months ago (2017-04-18 05:29:20 UTC) #4
tyoshino (SeeGerritForStatus)
lgtm
3 years, 8 months ago (2017-04-18 05:37:33 UTC) #5
tyoshino (SeeGerritForStatus)
On 2017/04/18 05:29:20, yhirano (slow) wrote: > I think measuring the duration is enough - ...
3 years, 8 months ago (2017-04-18 05:39:13 UTC) #6
kinuko
lgtm
3 years, 8 months ago (2017-04-18 05:43:25 UTC) #7
kinuko
lgtm
3 years, 8 months ago (2017-04-18 05:43:26 UTC) #8
yhirano
+isherman@ for histograms.xml change.
3 years, 8 months ago (2017-04-18 05:54:10 UTC) #10
Ilya Sherman
metrics lgtm
3 years, 8 months ago (2017-04-18 06:04:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820303002/1
3 years, 8 months ago (2017-04-18 06:50:10 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 07:35:48 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/56866c20d1252bb4ad9a6a0ed51a...

Powered by Google App Engine
This is Rietveld 408576698