Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2820223002: [wasm] Handle no initial memory case correctly when memory is exported (Closed)

Created:
3 years, 8 months ago by gdeepti
Modified:
3 years, 8 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com, ahaas
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Handle no initial memory case correctly when memory is exported Currently when the module has memory specified in the compiled bytes, but with no initial memory exported memory assigns a bogus buffer to the instance. When grow_memory is called on this buffer, it tries to patch an incorrect address. - Fix exported memory to handle no initial memory - Fix grow_memory to handle uninitialized buffers BUG=chromium:710844 R=bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2820223002 Cr-Commit-Position: refs/heads/master@{#44671} Committed: https://chromium.googlesource.com/v8/v8/+/78b8d7ed8ce1b70dd753b6b2a1f0a867d8be6104

Patch Set 1 #

Patch Set 2 : Fix bot failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M src/wasm/wasm-module.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/wasm/wasm-objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-objects.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M test/mjsunit/regress/wasm/regression-699485.js View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/wasm/regression-710844.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
gdeepti
3 years, 8 months ago (2017-04-17 23:42:21 UTC) #5
bradnelson
lgtm
3 years, 8 months ago (2017-04-17 23:46:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820223002/20001
3 years, 8 months ago (2017-04-18 06:32:42 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 06:34:25 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/78b8d7ed8ce1b70dd753b6b2a1f0a867d8b...

Powered by Google App Engine
This is Rietveld 408576698