Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2820213002: Fix naming in base/android/jni_utils. (Closed)

Created:
3 years, 8 months ago by estevenson
Modified:
3 years, 8 months ago
Reviewers:
Ted C, Torne
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix naming in base/android/jni_utils. Added in https://codereview.chromium.org/2501193003, IsSelectiveJniRegistrationEnabled() was missing a capital. BUG= Review-Url: https://codereview.chromium.org/2820213002 Cr-Commit-Position: refs/heads/master@{#465672} Committed: https://chromium.googlesource.com/chromium/src/+/15433f817c0cdcc0a0981c5af959dd61b452257a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M base/android/jni_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M base/android/jni_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_entry_point.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
estevenson
tedchoc@chromium.org: Please review changes in chrome_entry_point.cc torne@chromium.org: Please review changes in //base
3 years, 8 months ago (2017-04-19 13:11:23 UTC) #6
Torne
lgtm
3 years, 8 months ago (2017-04-19 16:33:12 UTC) #7
Ted C
lgtm
3 years, 8 months ago (2017-04-19 16:36:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820213002/1
3 years, 8 months ago (2017-04-19 17:33:05 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 18:16:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/15433f817c0cdcc0a0981c5af959...

Powered by Google App Engine
This is Rietveld 408576698