Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2820203003: [DMC #4] Add SingletonMarkerListImpl (Closed)

Created:
3 years, 8 months ago by rlanday
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SingletonMarkerListImpl This marker list implementation can be used for MarkerType where we never have more than one at a time. Right now, Composition is such a MarkerType. Once I add SuggestionBackgroundHighlight, that will be another type that can use this. I've removed a few test cases that tested behavior that's no longer valid (adding multiple composition markers, trying to get the rendered rects for composition markers). BUG=707867

Patch Set 1 #

Messages

Total messages: 5 (5 generated)
rlanday
rlanday@chromium.org changed reviewers: + xiaochengh@chromium.org, yosin@chromium.org
3 years, 8 months ago (2017-04-18 08:15:11 UTC) #1
rlanday
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-18 08:21:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820203003/1
3 years, 8 months ago (2017-04-18 08:21:42 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-18 08:53:28 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 08:53:29 UTC) #5
Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698