Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2820203002: cros Revert DCHECKs added in crbug.com/699798. (Closed)

Created:
3 years, 8 months ago by jdufault
Modified:
3 years, 8 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros Revert DCHECKs added in crbug.com/699798. BUG=699798 Review-Url: https://codereview.chromium.org/2820203002 Cr-Commit-Position: refs/heads/master@{#465684} Committed: https://chromium.googlesource.com/chromium/src/+/28cc7e40db7981ddcea21485ca17de6df59aa8a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/browser/ui/webui/chromeos/login/base_webui_handler.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jdufault
achuith@ PTAL. Thanks
3 years, 8 months ago (2017-04-19 00:16:24 UTC) #7
achuithb
lgtm
3 years, 8 months ago (2017-04-19 04:04:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820203002/1
3 years, 8 months ago (2017-04-19 18:27:30 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 18:57:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/28cc7e40db7981ddcea21485ca17...

Powered by Google App Engine
This is Rietveld 408576698