Worker: Raise an exception when an invalid feature number is passed to WorkerInternals::CountFeature

Worker: Raise an exception when an invalid feature number is passed to WorkerInternals::CountFeature

Before this CL, when an invalid feature number[1] is passed to
WorkerInternals::CountFeature/CountDeprecation, it ends up a check failure. This
is not a problem in real world applications because the internals APIs are used
only for testing, but it makes the fuzzer sad (see the report in the issue).

To make the fuzzer happy, this CL makes the functions raise an exception when
such an invalid value is given.

[1] feature < 0 || UseCounter::kNumberOfFeatures < feature

BUG=712003
Review-Url: https://codereview.chromium.org/2820193003
Cr-Commit-Position: refs/heads/master@{#465137}
Committed: https://chromium.googlesource.com/chromium/src/+/4b267ce12fab17dfa38615933571eae96faf63f1

[nhiroki, 2017-04-18 02:01:57]

Description was changed from

==========
Worker: Raise an exception when an invalid feature number is passed to
WorkerInternals::CountFeature

Before this CL, when an invalid feature number[1] is passed to
WorkerInternals::CountFeature/CountDeprecation, it ends up a check failure. This
is not a problem in real world applications because the internals APIs are used
only for testing, but it makes the fuzzer sad (see the report in the issue).

This CL makes the functions raise an exception when such an invalid value is
given to make the fuzzer happy.

[1] feature < 0 || UseCounter::kNumberOfFeatures < feature

BUG=712003
==========

to

==========
Worker: Raise an exception when an invalid feature number is passed to
WorkerInternals::CountFeature

Before this CL, when an invalid feature number[1] is passed to
WorkerInternals::CountFeature/CountDeprecation, it ends up a check failure. This
is not a problem in real world applications because the internals APIs are used
only for testing, but it makes the fuzzer sad (see the report in the issue).

To make the fuzzer happy, this CL makes the functions raise an exception when
such an invalid value is given.

[1] feature < 0 || UseCounter::kNumberOfFeatures < feature

BUG=712003
==========

[nhiroki, 2017-04-18 02:02:05]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 02:02:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-18 02:03:21]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org

[nhiroki, 2017-04-18 02:03:22]

PTAL, thanks!

[falken, 2017-04-18 04:02:01]

lgtm

[commit-bot: I haz the power, 2017-04-18 04:04:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 04:04:26]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-04-18 04:09:45]

nhiroki@chromium.org changed reviewers:
+ yutak@chromium.org

[nhiroki, 2017-04-18 04:09:45]

+yutak@, can you review this as an owner of core/? Thanks!

[Yuta Kitamura, 2017-04-18 04:22:04]

lgtm

[nhiroki, 2017-04-18 04:26:05]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2017-04-18 04:26:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 04:29:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492489565801960, "parent_rev":
"88ce9f2e84043c5f63cfb7a05cceffef8a581e97", "commit_rev":
"4b267ce12fab17dfa38615933571eae96faf63f1"}

[commit-bot: I haz the power, 2017-04-18 04:30:15]

Description was changed from

==========
Worker: Raise an exception when an invalid feature number is passed to
WorkerInternals::CountFeature

Before this CL, when an invalid feature number[1] is passed to
WorkerInternals::CountFeature/CountDeprecation, it ends up a check failure. This
is not a problem in real world applications because the internals APIs are used
only for testing, but it makes the fuzzer sad (see the report in the issue).

To make the fuzzer happy, this CL makes the functions raise an exception when
such an invalid value is given.

[1] feature < 0 || UseCounter::kNumberOfFeatures < feature

BUG=712003
==========

to

==========
Worker: Raise an exception when an invalid feature number is passed to
WorkerInternals::CountFeature

Before this CL, when an invalid feature number[1] is passed to
WorkerInternals::CountFeature/CountDeprecation, it ends up a check failure. This
is not a problem in real world applications because the internals APIs are used
only for testing, but it makes the fuzzer sad (see the report in the issue).

To make the fuzzer happy, this CL makes the functions raise an exception when
such an invalid value is given.

[1] feature < 0 || UseCounter::kNumberOfFeatures < feature

BUG=712003

Review-Url: https://codereview.chromium.org/2820193003
Cr-Commit-Position: refs/heads/master@{#465137}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b267ce12fab17dfa38615933571...
==========

[commit-bot: I haz the power, 2017-04-18 04:30:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4b267ce12fab17dfa38615933571...