Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 2820133005: Revert of Back PaintRecord with PaintOpBuffer instead of SkPicture (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
index d3b7553f9e31d6cbc3de2f228da01374837c4d05..e26681df44c5daedd2ecc73296c0992591234608 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
@@ -15,8 +15,6 @@
#include "platform/graphics/LoggingCanvas.h"
#include <stdio.h>
#endif
-
-static constexpr int kMaxNumberOfSlowPathsBeforeVeto = 5;
namespace blink {
@@ -537,7 +535,7 @@
!new_display_item_list_.IsEmpty())
GenerateChunkRasterInvalidationRects(new_paint_chunks_.LastChunk());
- int num_slow_paths = 0;
+ SkPictureGpuAnalyzer gpu_analyzer;
current_cache_generation_ =
DisplayItemClient::CacheGenerationOrInvalidationReason::Next();
@@ -556,8 +554,8 @@
Vector<const DisplayItemClient*> skipped_cache_clients;
for (const auto& item : new_display_item_list_) {
// No reason to continue the analysis once we have a veto.
- if (num_slow_paths <= kMaxNumberOfSlowPathsBeforeVeto)
- num_slow_paths += item.NumberOfSlowPaths();
+ if (gpu_analyzer.suitableForGpuRasterization())
+ item.AnalyzeForGpuRasterization(gpu_analyzer);
// TODO(wkorman): Only compute and append visual rect for drawings.
new_display_item_list_.AppendVisualRect(
@@ -595,7 +593,7 @@
new_display_item_list_.ShrinkToFit();
current_paint_artifact_ = PaintArtifact(
std::move(new_display_item_list_), new_paint_chunks_.ReleasePaintChunks(),
- num_slow_paths <= kMaxNumberOfSlowPathsBeforeVeto);
+ gpu_analyzer.suitableForGpuRasterization());
ResetCurrentListIndices();
out_of_order_item_indices_.Clear();
out_of_order_chunk_indices_.Clear();

Powered by Google App Engine
This is Rietveld 408576698