Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2820113008:
Roll WebGL fd73a60..73fd432 (Closed)
DescriptionRoll WebGL fd73a60..73fd432
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/fd73a60..73fd432
BUG=708730, 712584, 712117, 713127, angleproject:1966
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2820113008
Cr-Commit-Position: refs/heads/master@{#465664}
Committed: https://chromium.googlesource.com/chromium/src/+/9589135cc575bcaeb2b730df193ca9cbc408cec4
Patch Set 1 #Patch Set 2 : update expectations #Patch Set 3 : fix conflict #Patch Set 4 : upate an unrelated failure #
Total comments: 2
Messages
Total messages: 27 (22 generated)
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll WebGL fd73a60..73fd432 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/fd73a6... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL fd73a60..73fd432 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/fd73a6... BUG=708730, 712584, 712117, angleproject:1966 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
Description was changed from ========== Roll WebGL fd73a60..73fd432 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/fd73a6... BUG=708730, 712584, 712117, angleproject:1966 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL fd73a60..73fd432 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/fd73a6... BUG=708730, 712584, 712117, 713127, angleproject:1966 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
qiankun.miao@intel.com changed reviewers: + kbr@chromium.org, zmo@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2820113008/diff/60001/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2820113008/diff/60001/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:714: ['linux', 'nvidia'], bug=713127) Can you try roll with less commits and see exactly which one triggered this? Although this test isn't changed in this roll, but a test change before this test might affect it.
lgtm Let's land this roll and the suppression, and take the opportunity to debug this reproducible bug. https://codereview.chromium.org/2820113008/diff/60001/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2820113008/diff/60001/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:714: ['linux', 'nvidia'], bug=713127) On 2017/04/19 16:59:04, Zhenyao Mo wrote: > Can you try roll with less commits and see exactly which one triggered this? > Although this test isn't changed in this roll, but a test change before this > test might affect it. This failure is really strange. I would have thought it might be an unrelated change which slipped past the CQ because it didn't run the optional GPU tryservers, but it really seems to be caused by this WebGL conformance roll. Thinking about it more -- the addition of the new tests in this CL probably changed the distribution of tests among shards, and there is probably some bug in the browser which makes it sensitive to the order in which tests are run, causing them to fail if they're run in a certain order. I think we should push ahead with this conformance roll and take the opportunity to debug it. Updating http://crbug.com/713127 with more information.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492624077239650,
"parent_rev": "830962ad03b788b02aa7ac6d8dd02f0a38ba6d4b", "commit_rev":
"9589135cc575bcaeb2b730df193ca9cbc408cec4"}
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL fd73a60..73fd432 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/fd73a6... BUG=708730, 712584, 712117, 713127, angleproject:1966 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL fd73a60..73fd432 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/fd73a6... BUG=708730, 712584, 712117, 713127, angleproject:1966 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2820113008 Cr-Commit-Position: refs/heads/master@{#465664} Committed: https://chromium.googlesource.com/chromium/src/+/9589135cc575bcaeb2b730df193c... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/9589135cc575bcaeb2b730df193c... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
