Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Issue 2820103003: Disables more tests for ash_unittests --mus (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disables more tests for ash_unittests --mus And disables creation of a couple of objects in ash that make use of a class (DeviceDataManager) that is not created. BUG=712290, 705715 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2820103003 Cr-Commit-Position: refs/heads/master@{#465045} Committed: https://chromium.googlesource.com/chromium/src/+/dbfea6ff41a33e73312113c90f055ce7ac35ba1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M ash/shell.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M testing/buildbot/filters/ash_mus_unittests.filter View 4 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
sky
3 years, 8 months ago (2017-04-17 19:42:01 UTC) #1
msw
lgtm
3 years, 8 months ago (2017-04-17 20:08:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820103003/1
3 years, 8 months ago (2017-04-17 20:16:49 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 22:35:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dbfea6ff41a33e73312113c90f05...

Powered by Google App Engine
This is Rietveld 408576698