MD Settings: prevent input labels from shifting around.

MD Settings: prevent input labels from shifting around.

BUG=705460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2819963002
Cr-Commit-Position: refs/heads/master@{#465041}
Committed: https://chromium.googlesource.com/chromium/src/+/11b7a48b230e2d6fa29d5604cf2f7929acbc3b81

[scottchen, 2017-04-14 22:33:46]

Description was changed from

==========
MD Settings: prevent input labels from shifting around.

BUG=705460
==========

to

==========
MD Settings: prevent input labels from shifting around.

BUG=705460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-04-14 22:34:27]

scottchen@chromium.org changed reviewers:
+ dpapad@chromium.org

[scottchen, 2017-04-14 22:34:28]

scottchen@chromium.org changed reviewers:
+ dpapad@chromium.org

[scottchen, 2017-04-14 22:34:28]

thoughts on potential performance impacts and how to test to confirm/deny such
impacts?

[scottchen, 2017-04-14 22:34:28]

thoughts on potential performance impacts and how to test to confirm/deny such
impacts?

[dpapad, 2017-04-14 22:49:52]

On 2017/04/14 at 22:34:28, scottchen wrote:
> thoughts on potential performance impacts and how to test to confirm/deny such
impacts?

LGTM
I don't expert much impact, given that our text inputs are few (and usually
within <dialog> elements). We could dig in to the Performance view in devtools
to verify.

[dpapad, 2017-04-14 22:50:07]

https://codereview.chromium.org/2819963002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2819963002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_vars_css.html:101: transform:
translate3d(0, 0, 0);
Let's add a short comment here.

[scottchen, 2017-04-17 17:56:14]

On 2017/04/14 22:50:07, dpapad wrote:
>
https://codereview.chromium.org/2819963002/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/settings_vars_css.html (right):
> 
>
https://codereview.chromium.org/2819963002/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/settings_vars_css.html:101: transform:
> translate3d(0, 0, 0);
> Let's add a short comment here.

I had to apply the style directly on the element instead of the mixin, since it
was getting overridden in some places.
PTAL.

[dpapad, 2017-04-17 20:30:22]

On 2017/04/17 at 17:56:14, scottchen wrote:
> On 2017/04/14 22:50:07, dpapad wrote:
> >
https://codereview.chromium.org/2819963002/diff/1/chrome/browser/resources/se...
> > File chrome/browser/resources/settings/settings_vars_css.html (right):
> > 
> >
https://codereview.chromium.org/2819963002/diff/1/chrome/browser/resources/se...
> > chrome/browser/resources/settings/settings_vars_css.html:101: transform:
> > translate3d(0, 0, 0);
> > Let's add a short comment here.
> 
> I had to apply the style directly on the element instead of the mixin, since
it was getting overridden in some places.
> PTAL.

Still LGTM.

[scottchen, 2017-04-17 21:02:27]

The CQ bit was checked by scottchen@chromium.org

[commit-bot: I haz the power, 2017-04-17 21:02:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 22:10:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492462947086190,
"parent_rev": "95286bcd87997785c90c4194d65a430d082bc784", "commit_rev":
"11b7a48b230e2d6fa29d5604cf2f7929acbc3b81"}

[commit-bot: I haz the power, 2017-04-17 22:10:26]

Description was changed from

==========
MD Settings: prevent input labels from shifting around.

BUG=705460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: prevent input labels from shifting around.

BUG=705460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2819963002
Cr-Commit-Position: refs/heads/master@{#465041}
Committed:
https://chromium.googlesource.com/chromium/src/+/11b7a48b230e2d6fa29d5604cf2f...
==========

[commit-bot: I haz the power, 2017-04-17 22:10:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/11b7a48b230e2d6fa29d5604cf2f...