Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2819953002: Adjust visual overflow rect for rounded/shifted ascent/descent (Closed)

Created:
3 years, 8 months ago by Xianzhu
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, kinuko+watch, rwlbuis, krit, drott+blinkwatch_chromium.org, szager+layoutwatch_chromium.org, Justin Novosad, Rik, jchaffraix+rendering, blink-reviews, ajuma+watch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, Stephen Chennney, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, fmalita+watch_chromium.org, mac-reviews_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Adjust visual overflow rect for rounded/shifted ascent/descent For now we round and/or shift ascent and descent to integers in some cases, and we may layout using ascent/descent smaller than the original, causing that painted text at the laid-out position may overflow the visual overflow calculated based on layout geometries. Now record the loss in FontMetrics and adjust visual overflow rect to cover the overflows. BUG=706298 TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2803483002 Cr-Original-Commit-Position: refs/heads/master@{#464689} Review-Url: https://codereview.chromium.org/2819953002 Cr-Commit-Position: refs/branch-heads/3029@{#721} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/74f0a8230b1018a1071cd07beff0e3d6470a9ae4

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2854 lines, -25 lines) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/http/tests/security/img-crossorigin-no-credentials-prompt-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown-expected.txt View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/invalidation-rect-includes-newline-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/textarea-caret-expected.txt View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown-expected.txt View 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt View 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/textarea-caret-expected.txt View 1 chunk +72 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/control-clip-expected.txt View 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/control-clip-expected.txt View 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/flexbox/scrollbars-changed-expected.txt View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/inline-overflow-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/inline-reflow-expected.txt View 1 chunk +113 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/inline-vertical-lr-overflow-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/inline-vertical-rl-overflow-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-as-paint-container-expected.txt View 1 chunk +108 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-with-abspos-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-with-abspos-in-relpos-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-with-block-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-with-inline-expected.txt View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multicol-with-text-expected.txt View 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/push-block-with-first-line-expected.txt View 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/ruby-flipped-blocks-expected.txt View 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/text-in-relative-positioned-inline-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/vertical-rl-as-paint-container-expected.txt View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/flexbox/scrollbars-changed-expected.txt View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/inline-outline-repaint-2-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/inline-overflow-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/inline-reflow-expected.txt View 1 chunk +113 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/inline-vertical-lr-overflow-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/inline-vertical-rl-overflow-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/multicol-as-paint-container-expected.txt View 1 chunk +108 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/multicol-with-abspos-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/multicol-with-abspos-in-relpos-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/multicol-with-block-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/multicol-with-inline-expected.txt View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/multicol-with-text-expected.txt View 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/push-block-with-first-line-expected.txt View 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/ruby-flipped-blocks-expected.txt View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/text-in-relative-positioned-inline-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/vertical-rl-as-paint-container-expected.txt View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/http/tests/security/img-crossorigin-no-credentials-prompt-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/http/tests/security/img-crossorigin-no-credentials-prompt-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/SimpleFontData.h View 3 chunks +16 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp View 1 3 chunks +34 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819953002/20001
3 years, 8 months ago (2017-04-14 22:16:12 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 22:21:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/74f0a8230b1018a1071cd07beff0...

Powered by Google App Engine
This is Rietveld 408576698