Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2819883002: Remove usage of Tab's |url| property from MetricsMediator. (Closed)

Created:
3 years, 8 months ago by kkhorimoto
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of Tab's |url| property from MetricsMediator. BUG=546208 Review-Url: https://codereview.chromium.org/2819883002 Cr-Commit-Position: refs/heads/master@{#465680} Committed: https://chromium.googlesource.com/chromium/src/+/4d1da988bfeb8c480f8f92af9d328a428050255e

Patch Set 1 #

Total comments: 1

Patch Set 2 : Check for tab before getting URL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/app/application_delegate/metrics_mediator.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
kkhorimoto
https://codereview.chromium.org/2819883002/diff/1/ios/chrome/app/application_delegate/metrics_mediator.mm File ios/chrome/app/application_delegate/metrics_mediator.mm (right): https://codereview.chromium.org/2819883002/diff/1/ios/chrome/app/application_delegate/metrics_mediator.mm#newcode147 ios/chrome/app/application_delegate/metrics_mediator.mm:147: if (currentTab.lastCommittedURL == ntpUrl) { These metrics are gathered ...
3 years, 8 months ago (2017-04-14 20:28:51 UTC) #2
kkhorimoto
3 years, 8 months ago (2017-04-14 20:28:53 UTC) #3
Eugene But (OOO till 7-30)
lgtm
3 years, 8 months ago (2017-04-14 21:39:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819883002/1
3 years, 8 months ago (2017-04-18 21:24:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/196817)
3 years, 8 months ago (2017-04-18 22:10:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819883002/20001
3 years, 8 months ago (2017-04-19 18:37:24 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 18:51:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4d1da988bfeb8c480f8f92af9d32...

Powered by Google App Engine
This is Rietveld 408576698