Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2819863004: DevTools: Don't focus layers panel when it is shown (Closed)

Created:
3 years, 8 months ago by einbinder
Modified:
3 years, 7 months ago
Reviewers:
caseq, pfeldman, caseq1
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Don't focus layers panel when it is shown The layers panel ends up stealing focus and disrupting keyboard navigation. BUG=706699 Review-Url: https://codereview.chromium.org/2819863004 Cr-Commit-Position: refs/heads/master@{#468155} Committed: https://chromium.googlesource.com/chromium/src/+/1465b8cd7572282cebd6f05d226cc358cef80aec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/layers/LayersPanel.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
einbinder
ptal
3 years, 8 months ago (2017-04-17 21:42:36 UTC) #3
caseq1
lgtm
3 years, 7 months ago (2017-04-28 17:18:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819863004/1
3 years, 7 months ago (2017-04-28 20:25:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/423651)
3 years, 7 months ago (2017-04-28 20:40:21 UTC) #9
einbinder
On 2017/04/28 at 17:18:40, caseq wrote: > lgtm Can you switch to chromium account? Thanks.
3 years, 7 months ago (2017-04-28 22:17:25 UTC) #10
pfeldman
lgtm
3 years, 7 months ago (2017-04-28 22:18:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819863004/1
3 years, 7 months ago (2017-04-28 22:18:46 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 22:26:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1465b8cd7572282cebd6f05d226c...

Powered by Google App Engine
This is Rietveld 408576698