Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2819863003: Only run container name detection upon ffmpeg parse failure. (Closed)

Created:
3 years, 8 months ago by DaleCurtis
Modified:
3 years, 8 months ago
Reviewers:
jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only run container name detection upon ffmpeg parse failure. If ffmpeg thinks it can demux the file, we should defer to its result instead of trying to compute our own. This avoids any unnecessary delay in playback of supported formats by only running our checks if ffmpeg indicates it can't demux the content. BUG=711781 TEST=new unittests Review-Url: https://codereview.chromium.org/2819863003 Cr-Commit-Position: refs/heads/master@{#465003} Committed: https://chromium.googlesource.com/chromium/src/+/32a6c13991b642c992f9879bb808c527bc6dc278

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -20 lines) Patch
M media/base/container_names.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/container_names.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_glue.cc View 1 chunk +55 lines, -17 lines 2 comments Download
M media/filters/ffmpeg_glue_unittest.cc View 4 chunks +83 lines, -2 lines 0 comments Download
A media/test/data/bear.amr View Binary file 0 comments Download

Messages

Total messages: 13 (8 generated)
DaleCurtis
3 years, 8 months ago (2017-04-14 21:37:28 UTC) #2
jrummell
lgtm https://codereview.chromium.org/2819863003/diff/1/media/filters/ffmpeg_glue.cc File media/filters/ffmpeg_glue.cc (right): https://codereview.chromium.org/2819863003/diff/1/media/filters/ffmpeg_glue.cc#newcode171 media/filters/ffmpeg_glue.cc:171: if (strcmp(format_context_->iformat->name, "mov,mp4,m4a,3gp,3g2,mj2") == 0) Too bad there ...
3 years, 8 months ago (2017-04-17 18:00:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819863003/1
3 years, 8 months ago (2017-04-17 18:49:34 UTC) #9
DaleCurtis
https://codereview.chromium.org/2819863003/diff/1/media/filters/ffmpeg_glue.cc File media/filters/ffmpeg_glue.cc (right): https://codereview.chromium.org/2819863003/diff/1/media/filters/ffmpeg_glue.cc#newcode171 media/filters/ffmpeg_glue.cc:171: if (strcmp(format_context_->iformat->name, "mov,mp4,m4a,3gp,3g2,mj2") == 0) On 2017/04/17 at 18:00:15, ...
3 years, 8 months ago (2017-04-17 19:08:46 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 20:34:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/32a6c13991b642c992f9879bb808...

Powered by Google App Engine
This is Rietveld 408576698