Update GN roller for new JSON endpoints.

Update GN roller for new JSON endpoints.

Also, improve the error handling to exit cleanly and quickly with error messages 
when necessary.

R=hinoka@chromium.org

Review-Url: https://codereview.chromium.org/2819853003
Cr-Commit-Position: refs/heads/master@{#465414}
Committed: https://chromium.googlesource.com/chromium/src/+/53ca11c0fe7bbceeb9af4550c325e22201cbfc06

[Dirk Pranke, 2017-04-14 22:23:38]

Description was changed from

==========
Update GN roller for new JSON endpoints.

R=hinoka@chromium.org
BUG=
==========

to

==========
Update GN roller for new JSON endpoints.

R=hinoka@chromium.org
==========

[Dirk Pranke, 2017-04-14 22:24:05]

Description was changed from

==========
Update GN roller for new JSON endpoints.

R=hinoka@chromium.org
==========

to

==========
Update GN roller for new JSON endpoints.

Also, improve the error handling to exit cleanly and quickly with error messages

when necessary.

R=hinoka@chromium.org
==========

[hinoka, 2017-04-18 19:04:43]

lgtm + fix error handling

https://codereview.chromium.org/2819853003/diff/1/tools/gn/bin/roll_gn.py
File tools/gn/bin/roll_gn.py (right):

https://codereview.chromium.org/2819853003/diff/1/tools/gn/bin/roll_gn.py#new...
tools/gn/bin/roll_gn.py:230: except Exception as _e:
s/_e/e/

https://codereview.chromium.org/2819853003/diff/1/tools/gn/bin/roll_gn.py#new...
tools/gn/bin/roll_gn.py:239: except Exception as _e:
s/_e/e/

https://codereview.chromium.org/2819853003/diff/1/tools/gn/bin/roll_gn.py#new...
tools/gn/bin/roll_gn.py:271: 'http://chrome-build-extract.appspot.com/')
This is for querying a build right? This endpoint is just for individual builds.

[Dirk Pranke, 2017-04-18 19:21:33]

https://codereview.chromium.org/2819853003/diff/1/tools/gn/bin/roll_gn.py
File tools/gn/bin/roll_gn.py (right):

https://codereview.chromium.org/2819853003/diff/1/tools/gn/bin/roll_gn.py#new...
tools/gn/bin/roll_gn.py:230: except Exception as _e:
On 2017/04/18 19:04:43, hinoka wrote:
> s/_e/e/

Er, right. Will fix.

https://codereview.chromium.org/2819853003/diff/1/tools/gn/bin/roll_gn.py#new...
tools/gn/bin/roll_gn.py:239: except Exception as _e:
On 2017/04/18 19:04:43, hinoka wrote:
> s/_e/e/

Ditto.

https://codereview.chromium.org/2819853003/diff/1/tools/gn/bin/roll_gn.py#new...
tools/gn/bin/roll_gn.py:271: 'http://chrome-build-extract.appspot.com/')
On 2017/04/18 19:04:43, hinoka wrote:
> This is for querying a build right? This endpoint is just for individual
builds.

Yes, this is for querying individual builds. You can see that url_str comes from
the job['url'] field that Reitveld returns when we query it for the state of the
try jobs.

[Dirk Pranke, 2017-04-18 22:50:38]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2017-04-18 22:50:38]

The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@chromium.org
Link to the patchset: https://codereview.chromium.org/2819853003/#ps20001
(title: "fix error handling")

[commit-bot: I haz the power, 2017-04-18 22:51:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 23:05:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492555838421410,
"parent_rev": "1166f4428a18a1cacdeb9e4c310ee7b96cda63b6", "commit_rev":
"53ca11c0fe7bbceeb9af4550c325e22201cbfc06"}

[commit-bot: I haz the power, 2017-04-18 23:05:11]

Description was changed from

==========
Update GN roller for new JSON endpoints.

Also, improve the error handling to exit cleanly and quickly with error messages

when necessary.

R=hinoka@chromium.org
==========

to

==========
Update GN roller for new JSON endpoints.

Also, improve the error handling to exit cleanly and quickly with error messages

when necessary.

R=hinoka@chromium.org

Review-Url: https://codereview.chromium.org/2819853003
Cr-Commit-Position: refs/heads/master@{#465414}
Committed:
https://chromium.googlesource.com/chromium/src/+/53ca11c0fe7bbceeb9af4550c325...
==========

[commit-bot: I haz the power, 2017-04-18 23:05:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/53ca11c0fe7bbceeb9af4550c325...