Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2819853002: Import css21/abspos W3C CSS Test Suite (Closed)

Created:
3 years, 8 months ago by Gleb Lanbin
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Import css21/abspos W3C CSS Test Suite Import wpt@2ea12ebfd80b9802feb7f26938b90abda1a13de0 Using wpt-import in Chromium d3bc6148c7f0d2695ec2ca74652d996e2c4f5a6e. NOEXPORT=true BUG=711707 Review-Url: https://codereview.chromium.org/2819853002 Cr-Commit-Position: refs/heads/master@{#464795} Committed: https://chromium.googlesource.com/chromium/src/+/3e9c794b9ff12579e3f658dc62327fc63bbb73d5

Patch Set 1 #

Patch Set 2 : remove unrelated changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json View 1 3 chunks +301 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-001.xht View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-001-ref.xht View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-004-ref.xht View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-004a.xht View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-004b.xht View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-004c.xht View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-004d.xht View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-004e.xht View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-004f.xht View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-005-ref.xht View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-005a.xht View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-005b.xht View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-005c.xht View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-005d.xht View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-007.xht View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-007-ref.xht View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-009-ref.xht View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-009a.xht View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-009b.xht View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-009e.xht View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/CSS2/abspos/abspos-containing-block-initial-009f.xht View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Gleb Lanbin
3 years, 8 months ago (2017-04-14 18:04:57 UTC) #2
qyearsley
LGTM, although it looks like there are some failures in other tests that were dragged ...
3 years, 8 months ago (2017-04-14 18:51:20 UTC) #5
Gleb Lanbin
On 2017/04/14 18:51:20, qyearsley wrote: > LGTM, although it looks like there are some failures ...
3 years, 8 months ago (2017-04-14 21:03:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819853002/20001
3 years, 8 months ago (2017-04-14 21:10:17 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3e9c794b9ff12579e3f658dc62327fc63bbb73d5
3 years, 8 months ago (2017-04-14 21:16:05 UTC) #18
Dirk Pranke
On 2017/04/14 21:16:05, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as ...
3 years, 8 months ago (2017-04-14 22:27:40 UTC) #19
Gleb Lanbin
3 years, 8 months ago (2017-04-14 22:33:40 UTC) #20
Message was sent while issue was closed.
On 2017/04/14 22:27:40, Dirk Pranke wrote:
> On 2017/04/14 21:16:05, commit-bot: I haz the power wrote:
> > Committed patchset #2 (id:20001) as
> >
>
https://chromium.googlesource.com/chromium/src/+/3e9c794b9ff12579e3f658dc6232...
> 
> Can we prune the matching files from LayoutTests/css2.1/20110323 now?

I think most of LayoutTests/css2.1/20110323 tests are located in
csswg-test/css21/positioning. I'm importing that folder as well. Once I'm done I
will send a follow-up patch to clean up the old import.

Powered by Google App Engine
This is Rietveld 408576698