cc: Add more info to the BeginMainFrame dump.

cc: Add more info to the BeginMainFrame dump.

Add more info to determine if scheduler dropped frames. Change the dump
string to be proper JSON and increases the size to 50k. Make begin frame
source code compliant with the style guide.

R=brianderson
BUG=668892, 622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2819723002
Cr-Commit-Position: refs/heads/master@{#464849}
Committed: https://chromium.googlesource.com/chromium/src/+/73f0465777d91348d35874b5d2ebd28e5dfff138

[sunnyps, 2017-04-13 23:11:27]

Description was changed from

==========
cc: Add more info to the BeginMainFrame dump.

Adds info about commit completion waits for activation and if scheduler
dropped frames to reduce latency or because a missed frame exceeded
deadline. Changes the dump string to be proper JSON and increases the
size to 50k. Removes a few trailing underscores in the trace strings.

R=vmpstr,brianderson
BUG=668892,622080
==========

to

==========
cc: Add more info to the BeginMainFrame dump.

Adds info about commit completion waits for activation and if scheduler
dropped frames to reduce latency or because a missed frame exceeded
deadline. Changes the dump string to be proper JSON and increases the
size to 50k. Removes a few trailing underscores in the trace strings.

R=vmpstr,brianderson
BUG=668892,622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[sunnyps, 2017-04-13 23:12:10]

ptal

[sunnyps, 2017-04-13 23:12:17]

The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 23:12:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brianderson, 2017-04-13 23:31:37]

lgtm

[commit-bot: I haz the power, 2017-04-14 00:08:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 00:08:26]

Dry run: This issue passed the CQ dry run.

[sunnyps, 2017-04-14 23:20:52]

Description was changed from

==========
cc: Add more info to the BeginMainFrame dump.

Adds info about commit completion waits for activation and if scheduler
dropped frames to reduce latency or because a missed frame exceeded
deadline. Changes the dump string to be proper JSON and increases the
size to 50k. Removes a few trailing underscores in the trace strings.

R=vmpstr,brianderson
BUG=668892,622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Add more info to the BeginMainFrame dump.

Add more info to determine if scheduler dropped frames. Change the dump
string to be proper JSON and increases the size to 50k. Make begin frame
code compliant with the style guide.

R=brianderson
BUG=668892,622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[sunnyps, 2017-04-14 23:21:20]

Description was changed from

==========
cc: Add more info to the BeginMainFrame dump.

Add more info to determine if scheduler dropped frames. Change the dump
string to be proper JSON and increases the size to 50k. Make begin frame
code compliant with the style guide.

R=brianderson
BUG=668892,622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Add more info to the BeginMainFrame dump.

Add more info to determine if scheduler dropped frames. Change the dump
string to be proper JSON and increases the size to 50k. Make begin frame
source code compliant with the style guide.

R=brianderson
BUG=668892,622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[sunnyps, 2017-04-14 23:22:05]

I added some begin frame source state to the dump. PTAL again.

[sunnyps, 2017-04-14 23:24:11]

https://codereview.chromium.org/2819723002/diff/20001/cc/scheduler/begin_fram...
File cc/scheduler/begin_frame_source.cc (right):

https://codereview.chromium.org/2819723002/diff/20001/cc/scheduler/begin_fram...
cc/scheduler/begin_frame_source.cc:454: last_begin_frame_args_ = args;
NOTE: I don't set type to MISSED here because I want to dump what the incoming
args are. The type is set to MISSED before the args are sent as missed args to
an observer (see AddObserver).

[brianderson, 2017-04-14 23:42:59]

lgtm

[sunnyps, 2017-04-15 00:29:57]

The CQ bit was checked by sunnyps@chromium.org

[commit-bot: I haz the power, 2017-04-15 00:30:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 01:46:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492216197020680,
"parent_rev": "f21fa55c1594deac368f09c8847b451bea0c1bc2", "commit_rev":
"73f0465777d91348d35874b5d2ebd28e5dfff138"}

[commit-bot: I haz the power, 2017-04-15 01:47:38]

Description was changed from

==========
cc: Add more info to the BeginMainFrame dump.

Add more info to determine if scheduler dropped frames. Change the dump
string to be proper JSON and increases the size to 50k. Make begin frame
source code compliant with the style guide.

R=brianderson
BUG=668892,622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Add more info to the BeginMainFrame dump.

Add more info to determine if scheduler dropped frames. Change the dump
string to be proper JSON and increases the size to 50k. Make begin frame
source code compliant with the style guide.

R=brianderson
BUG=668892,622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2819723002
Cr-Commit-Position: refs/heads/master@{#464849}
Committed:
https://chromium.googlesource.com/chromium/src/+/73f0465777d91348d35874b5d2eb...
==========

[commit-bot: I haz the power, 2017-04-15 01:47:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/73f0465777d91348d35874b5d2eb...