[Extenisons Bindings] Don't throw unchecked errors; add console errors

extensions/renderer/script_context.cc

Index: extensions/renderer/script_context.cc
diff --git a/extensions/renderer/script_context.cc b/extensions/renderer/script_context.cc
index e171e0fffae9fcd6ce23a0c856ba7f8897ec2039..6f4bcfdac2b1bf34a482f85925ef8bdff27f1761 100644
--- a/extensions/renderer/script_context.cc
+++ b/extensions/renderer/script_context.cc
@@ -436,6 +436,20 @@ bool ScriptContext::HasAccessOrThrowError(const std::string& name) {
   return true;
 }
 
+void ScriptContext::AddMessageToConsole(content::ConsoleMessageLevel level,

[jbroman, 2017/04/19 17:45:05]

Why have both this and extensions::console::AddMessage (even if one calls the
other)? Why not either rewrite all calls to the latter to this one, or use
extensions::console::AddMessage in NativeExtensionBindingsSystem?

[Devlin, 2017/04/19 19:45:33]

Good question.  Removed.

+                                        const std::string& message) {
+  content::RenderFrame* render_frame = GetRenderFrame();
+  if (render_frame) {
+    render_frame->AddMessageToConsole(level, message);
+  } else {
+    // TODO(lazyboy/devlin): This can happen when this is the context for a
+    // service worker. blink::WebEmbeddedWorker has an AddMessageToConsole
+    // method that we could theoretically hook into.
+    LOG(WARNING) << "Could not log \"" << message
+                 << "\": no render frame found";
+  }
+}
+
 std::string ScriptContext::GetDebugString() const {
   DCHECK(thread_checker_.CalledOnValidThread());
   return base::StringPrintf(