[Extenisons Bindings] Don't throw unchecked errors; add console errors

extensions/renderer/script_context.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/script_context.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/strings/string_split.h"
@@ skipping 418 matching lines @@
   Feature::Availability availability = GetAvailability(name);
   if (!availability.is_available()) {
     isolate()->ThrowException(v8::Exception::Error(
         v8::String::NewFromUtf8(isolate(), availability.message().c_str())));
     return false;
   }
 
   return true;
 }
 
+void ScriptContext::AddMessageToConsole(content::ConsoleMessageLevel level,

[jbroman, 2017/04/19 17:45:05]

Why have both this and extensions::console::AddMessage (even if one calls the
other)? Why not either rewrite all calls to the latter to this one, or use
extensions::console::AddMessage in NativeExtensionBindingsSystem?

[Devlin, 2017/04/19 19:45:33]

Good question.  Removed.

+                                        const std::string& message) {
+  content::RenderFrame* render_frame = GetRenderFrame();
+  if (render_frame) {
+    render_frame->AddMessageToConsole(level, message);
+  } else {
+    // TODO(lazyboy/devlin): This can happen when this is the context for a
+    // service worker. blink::WebEmbeddedWorker has an AddMessageToConsole
+    // method that we could theoretically hook into.
+    LOG(WARNING) << "Could not log \"" << message
+                 << "\": no render frame found";
+  }
+}
+
 std::string ScriptContext::GetDebugString() const {
   DCHECK(thread_checker_.CalledOnValidThread());
   return base::StringPrintf(
       "  extension id:           %s\n"
       "  frame:                  %p\n"
       "  URL:                    %s\n"
       "  context_type:           %s\n"
       "  effective extension id: %s\n"
       "  effective context type: %s",
       extension_.get() ? extension_->id().c_str() : "(none)", web_frame_,
@@ skipping 77 matching lines @@
     v8::Local<v8::Value> argv[]) {
   return context_->CallFunction(function, argc, argv);
 }
 
 gin::ContextHolder* ScriptContext::Runner::GetContextHolder() {
   v8::HandleScope handle_scope(context_->isolate());
   return gin::PerContextData::From(context_->v8_context())->context_holder();
 }
 
 }  // namespace extensions