Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2819653002: Merged: Squashed multiple commits. (Closed)

Created:
3 years, 8 months ago by Michael Hablich
Modified:
3 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/branch-heads/5.8
Project:
v8
Visibility:
Public.

Description

Merged: Squashed multiple commits. Merged: [turbofan] Properly represent the float64 hole. Revision: 8c0c5e8117a0c935d6f2e5f6e540674d46753a87 Merged: [turbofan] Remove unused word32 truncation case for CheckFloat64Hole. Revision: 2eeb085427ccc7fbb58c7c8a8c5301f5f2b9d29f BUG=chromium:684208, chromium:684208, chromium:709753, chromium:709753, v8:5267, v8:5267 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2819653002 . Cr-Commit-Position: refs/branch-heads/5.8@{#64} Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1} Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429} Committed: https://chromium.googlesource.com/v8/v8/+/46013d6901425e3820a5f6378c5d1770f536dfb5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -56 lines) Patch
M src/compiler/js-create-lowering.cc View 2 chunks +2 lines, -21 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/operation-typer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/operation-typer.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 4 chunks +50 lines, -20 lines 0 comments Download
M src/compiler/typed-optimization.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typed-optimization.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/types.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-709753.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Hablich
3 years, 8 months ago (2017-04-13 21:17:16 UTC) #1
Michael Hablich
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 8 months ago (2017-04-13 21:17:17 UTC) #2
Michael Hablich
Committed patchset #1 (id:1) manually as 46013d6901425e3820a5f6378c5d1770f536dfb5.
3 years, 8 months ago (2017-04-13 21:18:19 UTC) #4
Michael Hablich
3 years, 8 months ago (2017-04-13 21:25:09 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2820603002/ by hablich@chromium.org.

The reason for reverting is: Breaks the build.

Powered by Google App Engine
This is Rietveld 408576698