cros: Update design of encryption migration UI for ext4 dircrypto.

cros: Update design of encryption migration UI for ext4 dircrypto.

This CL includes following changes:
- Update the layout/color/image to match the latest spec.
- Make all strings internationalized.
- Send "Charging" state from C++ side as the information is needed in the latest design.
- Send formatted size of available/necessary storage space as the information is needed in the latest design.
- Drop the final screen, since we should restart immediately on successful migration.

BUG=706017
TEST=manually tested each screen.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2819613003
Cr-Commit-Position: refs/heads/master@{#464586}
Committed: https://chromium.googlesource.com/chromium/src/+/3a85b3f42dd3103139419a68ee5e78b5c35596c4

[fukino, 2017-04-13 19:23:07]

Description was changed from

==========
cros: Update design of encryption migration UI for ext4 dircrypto.

BUG=
==========

to

==========
cros: Update design of encryption migration UI for ext4 dircrypto.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-04-13 19:23:20]

The CQ bit was checked by fukino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 19:24:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fukino, 2017-04-13 19:27:30]

Description was changed from

==========
cros: Update design of encryption migration UI for ext4 dircrypto.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Update design of encryption migration UI for ext4 dircrypto.

This CL includes following changes:
- Update the layout/color/image to match the latest spec.
- Make all strings internationalized.
- Send "Charging" state from C++ side as the information is needed in the latest
design.
- Send formatted size of available/necessary storage space as the information is
needed in the latest design.
- Drop the final screen, since we should restart immediately on successful
migration.

BUG=706017
TEST=manually tested each screen.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-04-13 19:28:57]

fukino@chromium.org changed reviewers:
+ xiyuan@chromium.org

[fukino, 2017-04-13 19:28:58]

Xiyuan, could you take a look?

[fukino, 2017-04-13 19:35:24]

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/encryption_migration.css (right):

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/encryption_migration.css:39:
url(images/chrome_icon_1x.png) 1x, url(images/chrome_icon_2x.png) 2x);
Chrome-logo's svg file was huge and complex even when I ran SVG optimizer on it.
Because of this, I use png file here.

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/ui/webui/chr...
File
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
(left):

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:153:
// TODO(fukino): If the migration finished successfully, we don't need to
According to the privacy review, we should not sign in automatically, since the
user may be away from the device when the migration finished.

According to dspaid@, "Restart" is preferable than just going back to sign-in
screen, as it can clear all intermediate state in cryptohome.

[xiyuan, 2017-04-13 20:33:09]

https://codereview.chromium.org/2819613003/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2819613003/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:5635: To download and use Android apps, first
you need to install an update. While your device is updating, you can’t use it.
Your Chromebook will restart after installation completes.
nit: Usually we use a place holder for "Chromebook" and use
SubstituteChromeOSDeviceType to replace it with proper device name. We should do
this for all 4 "Chromebook" here.

[1]:
https://cs.chromium.org/chromium/src/ash/system/devicetype_utils.cc?rcl=ecbbc...

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/encryption_migration.css (right):

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/encryption_migration.css:39:
url(images/chrome_icon_1x.png) 1x, url(images/chrome_icon_2x.png) 2x);
On 2017/04/13 19:35:23, fukino wrote:
> Chrome-logo's svg file was huge and complex even when I ran SVG optimizer on
it.
> Because of this, I use png file here.

Understand. But it is tricky when involving chrome icons since we need to handle
"Google Chrome" and "Chromium" case differently.

Can you do something similar to welcome UI [1] ? You can add the logo resources
in CreateOobeUIDataSource [2].

[1]:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/welcome_ui.cc?rc...
[2]:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/o...

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/ui/webui/chr...
File
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
(left):

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:153:
// TODO(fukino): If the migration finished successfully, we don't need to
On 2017/04/13 19:35:23, fukino wrote:
> According to the privacy review, we should not sign in automatically, since
the
> user may be away from the device when the migration finished.
> 
> According to dspaid@, "Restart" is preferable than just going back to sign-in
> screen, as it can clear all intermediate state in cryptohome.

Acknowledged.

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/ui/webui/chr...
File
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
(right):

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:138:
builder->Add("migrationButtonSignIn", IDS_ENCRYPTION_MIGRATION_BUTTON_SIGNIN);
IDS_ENCRYPTION_MIGRATION_BUTTON_SIGNIN seems not used ?

[fukino, 2017-04-13 21:33:41]

Thank you for the quick review!

https://codereview.chromium.org/2819613003/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2819613003/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:5635: To download and use Android apps, first
you need to install an update. While your device is updating, you can’t use it.
Your Chromebook will restart after installation completes.
On 2017/04/13 20:33:08, xiyuan wrote:
> nit: Usually we use a place holder for "Chromebook" and use
> SubstituteChromeOSDeviceType to replace it with proper device name. We should
do
> this for all 4 "Chromebook" here.
> 
> [1]:
>
https://cs.chromium.org/chromium/src/ash/system/devicetype_utils.cc?rcl=ecbbc...

Done.

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/encryption_migration.css (right):

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/encryption_migration.css:39:
url(images/chrome_icon_1x.png) 1x, url(images/chrome_icon_2x.png) 2x);
On 2017/04/13 20:33:08, xiyuan wrote:
> On 2017/04/13 19:35:23, fukino wrote:
> > Chrome-logo's svg file was huge and complex even when I ran SVG optimizer on
> it.
> > Because of this, I use png file here.
> 
> Understand. But it is tricky when involving chrome icons since we need to
handle
> "Google Chrome" and "Chromium" case differently.
> 
> Can you do something similar to welcome UI [1] ? You can add the logo
resources
> in CreateOobeUIDataSource [2].
> 
> [1]:
>
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/welcome_ui.cc?rc...
> [2]:
>
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/o...

Oh I did not know that there already is a product log in PNG format.
I removed the new PNGs and used IDR_PRODUCT_LOGO_64.
The logo is shown in 32px * 32px, so LOGO_64 should be sufficient for 1x and 2x
resolution.

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/ui/webui/chr...
File
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
(right):

https://codereview.chromium.org/2819613003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:138:
builder->Add("migrationButtonSignIn", IDS_ENCRYPTION_MIGRATION_BUTTON_SIGNIN);
On 2017/04/13 20:33:09, xiyuan wrote:
> IDS_ENCRYPTION_MIGRATION_BUTTON_SIGNIN seems not used ?

Sorry I should have mentioned this.
I add leave SIGNIN string intentionally.
At this moment we do Restart for safety, but I guess we might be requested to do
Sign in without restarting the device in the future and merge it to M59.
For such situation, I'd like to keep this string just in case, since we can't
add the string after the string freeze.

[xiyuan, 2017-04-13 21:45:29]

lgtm

[fukino, 2017-04-13 21:46:04]

On 2017/04/13 21:45:29, xiyuan wrote:
> lgtm

Thanks!

[fukino, 2017-04-13 21:46:07]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2017-04-13 21:47:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 22:51:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492119967650670,
"parent_rev": "68b0c507811e9712a819aaaea442dd32bbdf7b0e", "commit_rev":
"3a85b3f42dd3103139419a68ee5e78b5c35596c4"}

[commit-bot: I haz the power, 2017-04-13 22:52:18]

Description was changed from

==========
cros: Update design of encryption migration UI for ext4 dircrypto.

This CL includes following changes:
- Update the layout/color/image to match the latest spec.
- Make all strings internationalized.
- Send "Charging" state from C++ side as the information is needed in the latest
design.
- Send formatted size of available/necessary storage space as the information is
needed in the latest design.
- Drop the final screen, since we should restart immediately on successful
migration.

BUG=706017
TEST=manually tested each screen.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Update design of encryption migration UI for ext4 dircrypto.

This CL includes following changes:
- Update the layout/color/image to match the latest spec.
- Make all strings internationalized.
- Send "Charging" state from C++ side as the information is needed in the latest
design.
- Send formatted size of available/necessary storage space as the information is
needed in the latest design.
- Drop the final screen, since we should restart immediately on successful
migration.

BUG=706017
TEST=manually tested each screen.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2819613003
Cr-Commit-Position: refs/heads/master@{#464586}
Committed:
https://chromium.googlesource.com/chromium/src/+/3a85b3f42dd3103139419a68ee5e...
==========

[commit-bot: I haz the power, 2017-04-13 22:52:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3a85b3f42dd3103139419a68ee5e...