Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2819613002: Remove last remaining references to v8::Handle (all in comments/docs) in Blink. (Closed)

Created:
3 years, 8 months ago by jbroman
Modified:
3 years, 8 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove last remaining references to v8::Handle (all in comments/docs) in Blink. BUG=424445 Review-Url: https://codereview.chromium.org/2819613002 Cr-Commit-Position: refs/heads/master@{#464623} Committed: https://chromium.googlesource.com/chromium/src/+/2592d7bce3cd6c985c26fb0c13703d327838d540

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.md View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
jbroman
3 years, 8 months ago (2017-04-13 19:18:44 UTC) #4
haraken
LGTM
3 years, 8 months ago (2017-04-13 22:08:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819613002/1
3 years, 8 months ago (2017-04-14 00:17:53 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 00:26:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2592d7bce3cd6c985c26fb0c1370...

Powered by Google App Engine
This is Rietveld 408576698