Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2819583002: [turbofan] Introduce a dedicated Array type. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce a dedicated Array type. Use Type::Array to constant-fold Array.isArray builtin based on the value input type. Also use it to improve type based alias analysis, where we know that stores to an object of type Array don't affect stores to an object of type OtherObject, and vice versa. R=jarin@chromium.org BUG=v8:6262 Review-Url: https://codereview.chromium.org/2819583002 Cr-Commit-Position: refs/heads/master@{#44681} Committed: https://chromium.googlesource.com/v8/v8/+/199e543f7c2c514f3fea090c046313453c2ff497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M src/compiler/js-builtin-reducer.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/typer.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M src/compiler/types.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/types.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M test/cctest/test-types.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-13 17:38:11 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the Array type CL we cooked last week. It helps the LoadElimination ...
3 years, 8 months ago (2017-04-18 11:28:39 UTC) #6
Jarin
lgtm
3 years, 8 months ago (2017-04-18 11:31:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819583002/1
3 years, 8 months ago (2017-04-18 11:42:10 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 12:12:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/199e543f7c2c514f3fea090c046313453c2...

Powered by Google App Engine
This is Rietveld 408576698