Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2819483002: Parallel download browser test. (Closed)

Created:
3 years, 8 months ago by xingliu
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, David Trainor- moved to gerrit, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Parallel download browser test. This CL sets up a browser test fixture for parallel download. BUG=710576, 644352 Review-Url: https://codereview.chromium.org/2819483002 Cr-Commit-Position: refs/heads/master@{#466181} Committed: https://chromium.googlesource.com/chromium/src/+/8487c6bd015949404b45ad174f6b8fc806f95f2c

Patch Set 1 #

Patch Set 2 : Clean rebase. #

Patch Set 3 : Adjust due to a recent bug fix. #

Patch Set 4 : Fix compiling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -20 lines) Patch
M content/browser/download/download_browsertest.cc View 1 2 3 6 chunks +75 lines, -2 lines 0 comments Download
M content/browser/download/download_job_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/parallel_download_utils.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
M content/browser/download/parallel_download_utils.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download
M content/public/test/test_download_request_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/test/test_download_request_handler.cc View 4 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 31 (23 generated)
xingliu
3 years, 8 months ago (2017-04-13 00:58:50 UTC) #3
xingliu
Hi, PTAL, thanks.
3 years, 8 months ago (2017-04-13 00:59:36 UTC) #4
David Trainor- moved to gerrit
lgtm
3 years, 8 months ago (2017-04-19 22:46:32 UTC) #8
xingliu
alexmos@: Hi, Could you please take a look at the changes in these files, thank ...
3 years, 8 months ago (2017-04-20 03:36:37 UTC) #21
alexmos
content/public/test LGTM
3 years, 8 months ago (2017-04-20 09:07:10 UTC) #24
qinmin
lgtm
3 years, 8 months ago (2017-04-20 22:34:31 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819483002/60001
3 years, 8 months ago (2017-04-20 23:05:56 UTC) #28
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 23:14:47 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8487c6bd015949404b45ad174f6b...

Powered by Google App Engine
This is Rietveld 408576698