Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2819473003: Set TextInputType to some Textfields. (Closed)

Created:
3 years, 8 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
Peter Beverloo, sky
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tfarina, jam, darin-cc_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set TextInputType to some Textfields. BUG=705978 TEST=Open the virtual keyboard and focus on the textfield. Check that the keyboard for URL is used. Review-Url: https://codereview.chromium.org/2819473003 Cr-Commit-Position: refs/heads/master@{#465098} Committed: https://chromium.googlesource.com/chromium/src/+/df9f0738fe5536659fb8b5c405342a3d35aa2234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell_views.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
yhanada
sky@: Please take a look at bookmark_editor_view.cc. peter@: Please take a look at shell_views.cc. Thanks!
3 years, 8 months ago (2017-04-13 09:19:56 UTC) #6
Peter Beverloo
On 2017/04/13 09:19:56, yhanada wrote: > peter@: Please take a look at shell_views.cc. lgtm
3 years, 8 months ago (2017-04-13 13:41:59 UTC) #7
sky
LGTM
3 years, 8 months ago (2017-04-17 16:42:06 UTC) #8
yhanada
Thank you for reviewing!
3 years, 8 months ago (2017-04-18 00:30:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819473003/1
3 years, 8 months ago (2017-04-18 00:30:27 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 01:57:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df9f0738fe5536659fb8b5c40534...

Powered by Google App Engine
This is Rietveld 408576698