Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2819423005: [inspector] removed kDebugPromiseCollected event (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
dgozman, Yang
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] removed kDebugPromiseCollected event With recent CLs we always store maximum N async stack traces and when we reach limit we drop half of them. Current promise collected event requires creating weak handle: - it takes time, - it consumes memory. Since async task id distribution for promises is uniform (each new promise has last_async_task_id + 1 as an id) our hash map is good enough to handle any amount of async task ids, following time of executing 1 000 000 000 of lookups: - for empty hash map: 1.45 seconds, - for hash map with one entry: 14.95 seconds - 1024 entries: 15.03 seconds - 1024 * 1024 entries: 14.82 seconds - 1024 * 1024 * 1024: 17.9 seconds BUG=v8:6189 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2819423005 Cr-Commit-Position: refs/heads/master@{#44750} Committed: https://chromium.googlesource.com/v8/v8/+/189ffd9460e27638374f35c825036ee623107f38

Patch Set 1 #

Patch Set 2 : added a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -45 lines) Patch
M src/debug/debug.cc View 2 chunks +0 lines, -39 lines 0 comments Download
M src/debug/interface-types.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/inspector/test-interface.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/inspector/test-interface.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M src/inspector/v8-debugger.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/inspector/v8-debugger.cc View 1 2 chunks +10 lines, -4 lines 0 comments Download
A test/inspector/debugger/collect-obsolete-async-tasks.js View 1 1 chunk +35 lines, -0 lines 0 comments Download
A test/inspector/debugger/collect-obsolete-async-tasks-expected.txt View 1 1 chunk +37 lines, -0 lines 0 comments Download
M test/inspector/inspector-test.cc View 1 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
kozy
Dmitry and Yang, please take a look. Removing has only one disadvantage: if at any ...
3 years, 8 months ago (2017-04-18 17:11:54 UTC) #1
Yang
lgtm
3 years, 8 months ago (2017-04-18 18:30:22 UTC) #6
dgozman
Let's add a test which does a lot of promises with small limit and then ...
3 years, 8 months ago (2017-04-19 20:16:36 UTC) #7
dgozman
otherwise lgtm
3 years, 8 months ago (2017-04-19 20:16:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819423005/20001
3 years, 8 months ago (2017-04-20 00:55:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819423005/20001
3 years, 8 months ago (2017-04-20 15:47:25 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 15:49:10 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/189ffd9460e27638374f35c825036ee6231...

Powered by Google App Engine
This is Rietveld 408576698