Refactor extension app icon.

chrome/browser/chromeos/extensions/gfx_utils.cc

Index: chrome/browser/chromeos/extensions/gfx_utils.cc
diff --git a/chrome/browser/chromeos/extensions/gfx_utils.cc b/chrome/browser/chromeos/extensions/gfx_utils.cc
index 7683dc4684d141c60885644ef5f992fa7a770a6a..13259d47dca557dc4878575560b42072cd00fe31 100644
--- a/chrome/browser/chromeos/extensions/gfx_utils.cc
+++ b/chrome/browser/chromeos/extensions/gfx_utils.cc
@@ -94,6 +94,8 @@ const struct {
     // Google News
     {"com.google.android.apps.genie.geniewidget",
      "dllkocilcinkggkchnjgegijklcililc"},
+    // Used in unit tests.

[msw, 2017/05/03 01:17:37]

Could unit tests just use one of the above entries?

[khmel, 2017/05/03 02:15:21]

ARC test package name is defined here:
https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/arc/arc_app_t...

emfkafnhnpcmabnnkckkchdilgeoekbo is an extension in chrome/test.

Technically it is possible to do but this will require additional code change,
including existing unit tests were extension id are predefined and number of
tests is also predefined. Actually that was my intention initially to do like
this. But changes were big enough.
If you insist on removing this I can do it in separate issue in order not to
grow this cl.

[msw, 2017/05/08 19:59:53]

This is fine, at least for now, especially if the alternatives are more
complex...

[khmel, 2017/05/09 00:05:03]

Acknowledged.

+    {"fake.package.name1", "emfkafnhnpcmabnnkckkchdilgeoekbo"},

[msw, 2017/05/03 01:17:37]

The tests don't actually ever mention "fake.package.name1", is this mapping
needed? If so, perhaps explain why it's needed and actually check for
"fake.package.name1" in the tests?

[khmel, 2017/05/03 02:15:21]

Replied above.

 };
 
 // This class maintains the maps between the extension id and its equivalent