Refactor extension app icon.

chrome/browser/chromeos/extensions/gfx_utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/gfx_utils.h"
 
 #include "base/lazy_instance.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"
@@ skipping 76 matching lines @@
     {"com.google.android.apps.classroom", "mfhehppjhmmnlfbbopchdfldgimhfhfk"},
     // Google Hangouts
     {"com.google.android.talk", "knipolnnllmklapflnccelgolnpehhpl"},
     {"com.google.android.talk", "cgmlfbhkckbedohgdepgbkflommbfkep"},
     {"com.google.android.talk", "gldgpnmcpaogjlojhhpebkbbanacoglc"},
     // Google Play Music
     {"com.google.android.music", "fahmaaghhglfmonjliepjlchgpgfmobi"},
     // Google News
     {"com.google.android.apps.genie.geniewidget",
      "dllkocilcinkggkchnjgegijklcililc"},
+    // Used in unit tests.

[msw, 2017/05/03 01:17:37]

Could unit tests just use one of the above entries?

[khmel, 2017/05/03 02:15:21]

ARC test package name is defined here:
https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/arc/arc_app_t...

emfkafnhnpcmabnnkckkchdilgeoekbo is an extension in chrome/test.

Technically it is possible to do but this will require additional code change,
including existing unit tests were extension id are predefined and number of
tests is also predefined. Actually that was my intention initially to do like
this. But changes were big enough.
If you insist on removing this I can do it in separate issue in order not to
grow this cl.

[msw, 2017/05/08 19:59:53]

This is fine, at least for now, especially if the alternatives are more
complex...

[khmel, 2017/05/09 00:05:03]

Acknowledged.

+    {"fake.package.name1", "emfkafnhnpcmabnnkckkchdilgeoekbo"},

[msw, 2017/05/03 01:17:37]

The tests don't actually ever mention "fake.package.name1", is this mapping
needed? If so, perhaps explain why it's needed and actually check for
"fake.package.name1" in the tests?

[khmel, 2017/05/03 02:15:21]

Replied above.

 };
 
 // This class maintains the maps between the extension id and its equivalent
 // ARC package name.
 class AppDualBadgeMap {
  public:
   using ArcAppToExtensionsMap =
       std::unordered_map<std::string, std::vector<std::string>>;
   using ExtensionToArcAppMap = std::unordered_map<std::string, std::string>;
 
@@ skipping 102 matching lines @@
     resized_badge_image = gfx::ImageSkiaOperations::CreateResizedImage(
         *badge_image, skia::ImageOperations::RESIZE_BEST, icon_out->size());
   }
   *icon_out = gfx::ImageSkiaOperations::CreateSuperimposedImage(
       *icon_out, resized_badge_image);
   return;
 }
 
 }  // namespace util
 }  // namespace extensions