Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 2819373004: [ios] Fix WebStateListFastEnumerationHelper observer unregistration. (Closed)

Created:
3 years, 8 months ago by sdefresne
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fix WebStateListFastEnumerationHelper observer unregistration. Convert WebStateListFastEnumerationHelper to use RAII to automatically unregister the WebStateListObserver from the WebStateList observer list. BUG=712391 Review-Url: https://codereview.chromium.org/2819373004 Cr-Commit-Position: refs/heads/master@{#465572} Committed: https://chromium.googlesource.com/chromium/src/+/4a0a4e85d2a8d23a9aeb528bec0dac702b43c5f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -24 lines) Patch
M ios/chrome/browser/tabs/tab_model.mm View 3 chunks +8 lines, -8 lines 0 comments Download
M ios/chrome/browser/web_state_list/web_state_list_fast_enumeration_helper.h View 2 chunks +15 lines, -6 lines 0 comments Download
M ios/chrome/browser/web_state_list/web_state_list_fast_enumeration_helper.mm View 5 chunks +39 lines, -3 lines 0 comments Download
M ios/chrome/browser/web_state_list/web_state_list_fast_enumeration_helper_unittest.mm View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sdefresne
Please take a look and send to CQ if LGTY.
3 years, 8 months ago (2017-04-18 17:00:39 UTC) #4
rohitrao (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-19 11:28:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819373004/1
3 years, 8 months ago (2017-04-19 13:11:14 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 13:16:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4a0a4e85d2a8d23a9aeb528bec0d...

Powered by Google App Engine
This is Rietveld 408576698