Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2819373003: Enable once flaky tests in Chrome OS file manager. (Closed)

Created:
3 years, 8 months ago by tetsui2
Modified:
3 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable once flaky tests in Chrome OS file manager. These tests were previously flaky and there seems to be a shared issue. However, they do not reproduce anymore on the latest master branch. BUG=701022, 701021, 700834, 700502, 700448, 700430 TEST=out/Release/browser_tests '--gtest_filter=*FileManager*' --gtest_repeat=100 Review-Url: https://codereview.chromium.org/2819373003 Cr-Commit-Position: refs/heads/master@{#465105} Committed: https://chromium.googlesource.com/chromium/src/+/ac8387db525f523dcc307064755792498ae0d192

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
tetsui2
Please take a look. I ran the following command and all tests passed. ninja -j500 ...
3 years, 8 months ago (2017-04-18 01:51:04 UTC) #2
fukino
lgtm. Could you add the following line to the bug description? TEST=out/Release/browser_tests '--gtest_filter=*FileManager*' --gtest_repeat=100
3 years, 8 months ago (2017-04-18 01:55:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819373003/1
3 years, 8 months ago (2017-04-18 02:02:18 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 02:31:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac8387db525f523dcc3070647557...

Powered by Google App Engine
This is Rietveld 408576698