Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2819323002: Merge M59: "Start reporting watch time if ABR adapts above 200p." (Closed)

Created:
3 years, 8 months ago by DaleCurtis
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge M59: "Start reporting watch time if ABR adapts above 200p." Previously we only checked the initial resolution and assumed it was always large enough to start watch time reporting; clearly this is not true since YouTube offers a 140p format. Probably we also want to drop the minimum resolution to 200x140p, which I'll check with product about and handle in a followup CL. BUG=711792 TEST=new tests. Manual: force 140p, adapt above, verify watch time. Review-Url: https://codereview.chromium.org/2822543006 Cr-Commit-Position: refs/heads/master@{#464826} (cherry picked from commit 2540556a43a467a11d4c2cffdb9457b97d8b94c4) Review-Url: https://codereview.chromium.org/2819323002 . Cr-Commit-Position: refs/branch-heads/3071@{#21} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/4c8965aac50f0f4772195c2088404b1bc040dc5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M media/blink/watch_time_reporter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/blink/watch_time_reporter.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M media/blink/watch_time_reporter_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
3 years, 8 months ago (2017-04-17 19:03:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c8965aac50f0f4772195c2088404b1bc040dc5b.

Powered by Google App Engine
This is Rietveld 408576698