Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2819293003: Fix more g_k_* symbols after blink rename. (Closed)

Created:
3 years, 8 months ago by Łukasz Anforowicz
Modified:
3 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, lunalu1, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, Rik, Justin Novosad, iclelland, blink-reviews, kinuko+watch, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis, dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix more g_k_* symbols after blink rename. Majority of g_k_* symbols were fixed by r463712 - this CL fixes 2 more cases. These were renamed because these weren't actually const in most cases, so also make all these constants actually constant in addition to renaming them. No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2819293003 Cr-Commit-Position: refs/heads/master@{#465309} Committed: https://chromium.googlesource.com/chromium/src/+/76e13266457493c2c9a3c5a3c412e4ac713fbcc1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Łukasz Anforowicz
thakis@, could you PTAL? No rush - this can wait until you've caught up after ...
3 years, 8 months ago (2017-04-18 17:26:57 UTC) #4
Nico
lgtm I wonder why I missed those!
3 years, 8 months ago (2017-04-18 17:40:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819293003/1
3 years, 8 months ago (2017-04-18 18:42:24 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 18:55:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76e13266457493c2c9a3c5a3c412...

Powered by Google App Engine
This is Rietveld 408576698