Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2819283005: [inspector] Fix double rules warning when compiling inspector with GYP (Closed)

Created:
3 years, 8 months ago by ivica.bogosavljevic
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org, v8-mips-ports_googlegroups.com, v8-arm-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Fix double rules warning when compiling inspector with GYP When cross compiling inspector with GYP on MIPS and ARM, there are three rules that generate the same file both host toolset and target toolset. This causes problems because of rule duplication; depending on compilation configuration this can cause warning or error. We fix this by disabling the host rule and using target rule for all depending rules. BUG=v8:6176 Review-Url: https://codereview.chromium.org/2819283005 Cr-Commit-Position: refs/heads/master@{#44741} Committed: https://chromium.googlesource.com/v8/v8/+/3b217d4245e38ea6e0c59dfeaffd6838681e852c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -31 lines) Patch
M src/inspector/inspector.gyp View 4 chunks +4 lines, -28 lines 0 comments Download
M src/v8.gyp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
ivica.bogosavljevic
PTAL
3 years, 8 months ago (2017-04-19 08:08:51 UTC) #2
Michael Achenbach
lgtm +kozy
3 years, 8 months ago (2017-04-19 08:19:39 UTC) #4
kozy
lgtm
3 years, 8 months ago (2017-04-19 16:55:08 UTC) #9
kozy
please wait for Yang's lgtm.
3 years, 8 months ago (2017-04-19 16:56:32 UTC) #10
Yang
On 2017/04/19 16:56:32, kozy wrote: > please wait for Yang's lgtm. LGTM. Thanks!
3 years, 8 months ago (2017-04-20 08:52:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819283005/1
3 years, 8 months ago (2017-04-20 12:17:01 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 12:39:03 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3b217d4245e38ea6e0c59dfeaffd6838681...

Powered by Google App Engine
This is Rietveld 408576698