[ObjC ARC] Converts ios/chrome/browser/ui/util:util to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/util:util to ARC.

Automatically generated ARCMigrate commit
Notable issues:static_cast changed to __bridge cast.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2819283004
Cr-Commit-Position: refs/heads/master@{#467946}
Committed: https://chromium.googlesource.com/chromium/src/+/8f67705094cf459bb5eda915a47bc2780cc22868

[gambard, 2017-04-18 12:54:46]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 12:55:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gambard, 2017-04-18 14:02:47]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/util:util to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/util:util to ARC.

Automatically generated ARCMigrate commit
Notable issues:static_cast changed to __bridge cast.
BUG=624363
TEST=None
==========

[gambard, 2017-04-18 14:35:24]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 14:35:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 16:31:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 16:31:41]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[gambard, 2017-04-19 15:50:00]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 15:50:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 17:07:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 17:07:29]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[gambard, 2017-04-21 11:31:59]

gambard@chromium.org changed reviewers:
+ marq@chromium.org, stkhapugin@chromium.org

[gambard, 2017-04-21 11:32:00]

PTAL.

[gambard, 2017-04-21 11:32:05]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 11:32:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 12:30:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 12:30:20]

Dry run: This issue passed the CQ dry run.

[gambard, 2017-04-21 13:28:56]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 13:29:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 14:41:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 14:41:08]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2017-04-21 16:25:04]

https://codereview.chromium.org/2819283004/diff/80001/ios/chrome/browser/ui/u...
File ios/chrome/browser/ui/util/core_text_util.mm (right):

https://codereview.chromium.org/2819283004/diff/80001/ios/chrome/browser/ui/u...
ios/chrome/browser/ui/util/core_text_util.mm:32: CTLineRef line = (__bridge
CTLineRef)(line_id);
We should still use static_cast<>() even if we're using __bridge, right?

https://codereview.chromium.org/2819283004/diff/80001/ios/chrome/browser/ui/u...
File ios/chrome/browser/ui/util/text_frame.mm (right):

https://codereview.chromium.org/2819283004/diff/80001/ios/chrome/browser/ui/u...
ios/chrome/browser/ui/util/text_frame.mm:36: _line = (__bridge id)(line);
static cast

[sdefresne, 2017-04-24 11:30:02]

https://codereview.chromium.org/2819283004/diff/80001/ios/chrome/browser/ui/u...
File ios/chrome/browser/ui/util/core_text_util.mm (right):

https://codereview.chromium.org/2819283004/diff/80001/ios/chrome/browser/ui/u...
ios/chrome/browser/ui/util/core_text_util.mm:32: CTLineRef line = (__bridge
CTLineRef)(line_id);
On 2017/04/21 16:25:04, marq wrote:
> We should still use static_cast<>() even if we're using __bridge, right?

Sadly "bridge" and "static_cast" don't mix. This is why we have a
BASE_MAC_BRIDGE_CAST in base/mac/scoped_block.h.

[stkhapugin, 2017-04-26 10:40:29]

lgtm with others' comments

[gambard, 2017-04-27 08:28:45]

On 2017/04/26 10:40:29, stkhapugin wrote:
> lgtm with others' comments

I guess the answer to the comment is: "this is fine".
marq: PTAL

[marq (ping after 24h), 2017-04-28 08:33:34]

lgtm

[gambard, 2017-04-28 08:59:22]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2017-04-28 08:59:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 09:59:37]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493369962664540,
"parent_rev": "5db6d1582b5525b719efa7fe0206a8b820edd0bc", "commit_rev":
"8f67705094cf459bb5eda915a47bc2780cc22868"}

[commit-bot: I haz the power, 2017-04-28 09:59:44]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/util:util to ARC.

Automatically generated ARCMigrate commit
Notable issues:static_cast changed to __bridge cast.
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/util:util to ARC.

Automatically generated ARCMigrate commit
Notable issues:static_cast changed to __bridge cast.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2819283004
Cr-Commit-Position: refs/heads/master@{#467946}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f67705094cf459bb5eda915a47b...
==========

[commit-bot: I haz the power, 2017-04-28 09:59:51]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8f67705094cf459bb5eda915a47b...