Internet: Show device enabling and scanning states

Internet: Show device enabling and scanning states

BUG=701945
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2819253002
Cr-Commit-Position: refs/heads/master@{#465647}
Committed: https://chromium.googlesource.com/chromium/src/+/cdada755fecf17a13796dc49b7633c679cf7e84e

[stevenjb, 2017-04-17 16:30:40]

Description was changed from

==========
Internet: Show device enabling and scanning states

BUG=701945
==========

to

==========
Internet: Show device enabling and scanning states

BUG=701945
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-17 17:48:22]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2017-04-17 20:33:26]

lgtm

https://codereview.chromium.org/2819253002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/network_summary.js (right):

https://codereview.chromium.org/2819253002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_summary.js:279:
newDeviceStates = Object.assign({}, this.deviceStates);
This is subtle, since the assignment to |this.deviceStates| is ~60 lines down.
Would it be worthwhile to factor out some helper methods for setting up
newDeviceStates, newNetworkStateLists, and newActiveNetworkStates from the
blocks below?

[michaelpg, 2017-04-17 20:33:27]

lgtm

lgtm

https://codereview.chromium.org/2819253002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/network_summary.js (right):

https://codereview.chromium.org/2819253002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_summary.js:279:
newDeviceStates = Object.assign({}, this.deviceStates);
This is subtle, since the assignment to |this.deviceStates| is ~60 lines down.
Would it be worthwhile to factor out some helper methods for setting up
newDeviceStates, newNetworkStateLists, and newActiveNetworkStates from the
blocks below?

[michaelpg, 2017-04-17 20:33:47]

On 2017/04/17 20:33:27, michaelpg wrote:

whoops, sent duplicate messages.

[stevenjb, 2017-04-17 20:41:31]

https://codereview.chromium.org/2819253002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/network_summary.js (right):

https://codereview.chromium.org/2819253002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_summary.js:279:
newDeviceStates = Object.assign({}, this.deviceStates);
On 2017/04/17 20:33:27, michaelpg wrote:
> This is subtle, since the assignment to |this.deviceStates| is ~60 lines down.
> Would it be worthwhile to factor out some helper methods for setting up
> newDeviceStates, newNetworkStateLists, and newActiveNetworkStates from the
> blocks below?

I actually have a CL that cleans this up some. It doesn't really help with
efficiency (which is what I was aiming for), but is probably worth committing as
a cleanup CL. Stay tuned :)

[stevenjb, 2017-04-19 16:09:21]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-04-19 16:09:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2819253002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-19 16:09:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 17:15:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492618161131310,
"parent_rev": "8dd1fcb848c35f9d4883c0d9c0aa42be3d627fd0", "commit_rev":
"cdada755fecf17a13796dc49b7633c679cf7e84e"}

[commit-bot: I haz the power, 2017-04-19 17:15:58]

Description was changed from

==========
Internet: Show device enabling and scanning states

BUG=701945
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Internet: Show device enabling and scanning states

BUG=701945
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2819253002
Cr-Commit-Position: refs/heads/master@{#465647}
Committed:
https://chromium.googlesource.com/chromium/src/+/cdada755fecf17a13796dc49b763...
==========

[commit-bot: I haz the power, 2017-04-19 17:15:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cdada755fecf17a13796dc49b763...