Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2819183004: [Autofill] Change MasterCard to Mastercard in UI and related tests (Closed)

Created:
3 years, 8 months ago by jiahuiguo
Modified:
3 years, 7 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, mathp+autofillwatch_chromium.org, mahmadi+paymentswatch_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

This cl changed "MasterCard" to "Mastercard" in the UI and related tests, since the brand is switched to lowercase 'c' last year, Payments side also had such an effort done. Files touched are based on this filter: "MasterCard" package:^chromium$ case:yes exact:yes -f:xtb -f:.dic -f:.heuristics -f:.js -f:third_party -f:.html and "Master Card" package:^chromium$ case:yes exact:yes -f:xtb -f:.dic -f:.heuristics -f:.js -f:third_party -f:.html TEST=components:components_unittests Review-Url: https://codereview.chromium.org/2819183004 Cr-Commit-Position: refs/heads/master@{#473641} Committed: https://chromium.googlesource.com/chromium/src/+/b65043769fd66a4a1baf6dbb811127f67ed6beae

Patch Set 1 #

Patch Set 2 #

Total comments: 4

Patch Set 3 : Change some in comments #

Patch Set 4 #

Total comments: 2

Patch Set 5 #

Total comments: 3

Patch Set 6 : Address comments. #

Patch Set 7 : Resolve conflict #

Patch Set 8 : Resolved conflict #

Patch Set 9 : Resolved conflict #

Messages

Total messages: 81 (52 generated)
jiahuiguo
Hi Mathieu and Jared, PTAL.
3 years, 8 months ago (2017-04-18 01:15:02 UTC) #10
Jared Saul
https://codereview.chromium.org/2819183004/diff/20001/components/autofill/core/browser/credit_card_field.cc File components/autofill/core/browser/credit_card_field.cc (right): https://codereview.chromium.org/2819183004/diff/20001/components/autofill/core/browser/credit_card_field.cc#newcode315 components/autofill/core/browser/credit_card_field.cc:315: // a pretty common mistake; e.g., "Master Card" instead ...
3 years, 8 months ago (2017-04-18 01:21:57 UTC) #11
jiahuiguo
Thanks. https://codereview.chromium.org/2819183004/diff/20001/components/autofill/core/browser/credit_card_field.cc File components/autofill/core/browser/credit_card_field.cc (right): https://codereview.chromium.org/2819183004/diff/20001/components/autofill/core/browser/credit_card_field.cc#newcode315 components/autofill/core/browser/credit_card_field.cc:315: // a pretty common mistake; e.g., "Master Card" ...
3 years, 8 months ago (2017-04-18 17:58:04 UTC) #24
Jared Saul
lgtm https://codereview.chromium.org/2819183004/diff/60001/components/autofill/core/browser/autofill_manager_unittest.cc File components/autofill/core/browser/autofill_manager_unittest.cc (right): https://codereview.chromium.org/2819183004/diff/60001/components/autofill/core/browser/autofill_manager_unittest.cc#newcode2651 components/autofill/core/browser/autofill_manager_unittest.cc:2651: std::vector<const char*> kCreditCardTypes = {"Visa", "Mastercard", "AmEx", Should ...
3 years, 8 months ago (2017-04-18 18:24:19 UTC) #25
jiahuiguo
https://codereview.chromium.org/2819183004/diff/60001/components/autofill/core/browser/autofill_manager_unittest.cc File components/autofill/core/browser/autofill_manager_unittest.cc (right): https://codereview.chromium.org/2819183004/diff/60001/components/autofill/core/browser/autofill_manager_unittest.cc#newcode2651 components/autofill/core/browser/autofill_manager_unittest.cc:2651: std::vector<const char*> kCreditCardTypes = {"Visa", "Mastercard", "AmEx", On 2017/04/18 ...
3 years, 8 months ago (2017-04-18 20:58:51 UTC) #27
Mathieu
lgtm with nit Thanks for the fix! https://codereview.chromium.org/2819183004/diff/80001/components/autofill/core/browser/autofill_field_unittest.cc File components/autofill/core/browser/autofill_field_unittest.cc (right): https://codereview.chromium.org/2819183004/diff/80001/components/autofill/core/browser/autofill_field_unittest.cc#newcode815 components/autofill/core/browser/autofill_field_unittest.cc:815: field, ASCIIToUTF16("Mastercard"), ...
3 years, 8 months ago (2017-04-23 08:23:49 UTC) #32
Jared Saul
https://codereview.chromium.org/2819183004/diff/80001/components/autofill/core/browser/autofill_field_unittest.cc File components/autofill/core/browser/autofill_field_unittest.cc (right): https://codereview.chromium.org/2819183004/diff/80001/components/autofill/core/browser/autofill_field_unittest.cc#newcode815 components/autofill/core/browser/autofill_field_unittest.cc:815: field, ASCIIToUTF16("Mastercard"), "en-US", "en-US", &field); On 2017/04/23 08:23:48, Mathieu ...
3 years, 8 months ago (2017-04-24 17:41:08 UTC) #33
jiahuiguo
PTAL. Thanks. https://codereview.chromium.org/2819183004/diff/80001/components/autofill/core/browser/autofill_field_unittest.cc File components/autofill/core/browser/autofill_field_unittest.cc (right): https://codereview.chromium.org/2819183004/diff/80001/components/autofill/core/browser/autofill_field_unittest.cc#newcode815 components/autofill/core/browser/autofill_field_unittest.cc:815: field, ASCIIToUTF16("Mastercard"), "en-US", "en-US", &field); On 2017/04/23 ...
3 years, 8 months ago (2017-04-25 20:20:32 UTC) #36
Mathieu
On 2017/04/25 20:20:32, jiahuiguo wrote: > PTAL. Thanks. > > https://codereview.chromium.org/2819183004/diff/80001/components/autofill/core/browser/autofill_field_unittest.cc > File components/autofill/core/browser/autofill_field_unittest.cc (right): ...
3 years, 7 months ago (2017-05-09 17:44:44 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819183004/120001
3 years, 7 months ago (2017-05-10 00:16:22 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 02:19:48 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819183004/120001
3 years, 7 months ago (2017-05-10 02:22:03 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 04:24:12 UTC) #48
jiahuiguo
Hi jochen@, PTAL chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java Thanks
3 years, 7 months ago (2017-05-10 18:56:46 UTC) #51
jochen (gone - plz use gerrit)
On 2017/05/10 at 18:56:46, jiahuiguo wrote: > Hi jochen@, > > PTAL chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java > > ...
3 years, 7 months ago (2017-05-11 08:00:22 UTC) #52
jiahuiguo
Hi rouslan@, PTAL chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java Thanks
3 years, 7 months ago (2017-05-12 06:29:28 UTC) #55
please use gerrit instead
PersonalDataManagerTest.java LGTM
3 years, 7 months ago (2017-05-12 14:07:28 UTC) #56
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819183004/120001
3 years, 7 months ago (2017-05-12 17:11:53 UTC) #58
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/266988) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 7 months ago (2017-05-12 17:18:03 UTC) #60
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819183004/140001
3 years, 7 months ago (2017-05-13 01:33:44 UTC) #63
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/436164)
3 years, 7 months ago (2017-05-13 01:43:53 UTC) #65
jiahuiguo
Hi brettw@, Needs your approval for chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java. Thanks.
3 years, 7 months ago (2017-05-15 19:28:47 UTC) #67
brettw
On 2017/05/15 19:28:47, jiahuiguo wrote: > Hi brettw@, > > Needs your approval for > ...
3 years, 7 months ago (2017-05-19 20:43:12 UTC) #68
jiahuiguo
Hi Tedchoc@, Needs your approval for chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java. Thanks.
3 years, 7 months ago (2017-05-19 20:52:06 UTC) #70
Ted C
On 2017/05/19 20:52:06, jiahuiguo wrote: > Hi Tedchoc@, > > Needs your approval for > ...
3 years, 7 months ago (2017-05-19 21:32:07 UTC) #71
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819183004/160001
3 years, 7 months ago (2017-05-19 23:57:45 UTC) #74
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/298792)
3 years, 7 months ago (2017-05-20 03:18:24 UTC) #76
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819183004/160001
3 years, 7 months ago (2017-05-22 17:49:08 UTC) #78
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 18:52:52 UTC) #81
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/b65043769fd66a4a1baf6dbb8111...

Powered by Google App Engine
This is Rietveld 408576698