third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js - Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js

Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain (Closed)

Patch Set: rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js ('K') | « third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/ResourcesSection.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/OverlayModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js

diff --git a/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js b/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js

index f0558a03273db9b5791001f89c2f68ef2936940f..abc625eb07068896cd8840d1a7fd81ca60dc2724 100644

--- a/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js

+++ b/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js

@@ -306,8 +306,8 @@ ObjectUI.ObjectPropertiesSection = class extends UI.TreeOutlineInShadow {

Common.Revealer.reveal(value);

event.consume(true);

}, false);

- valueElement.addEventListener('mousemove', () => SDK.DOMModel.highlightObjectAsDOMNode(value), false);

- valueElement.addEventListener('mouseleave', () => SDK.DOMModel.hideDOMNodeHighlight(), false);

+ valueElement.addEventListener('mousemove', () => SDK.OverlayModel.highlightObjectAsDOMNode(value), false);

+ valueElement.addEventListener('mouseleave', () => SDK.OverlayModel.hideDOMNodeHighlight(), false);

return valueElement;

}