third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js - Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js

Issue 2819183002: [DevTools] Consolidate overlay-related functionality in Overlay domain (Closed)

Patch Set: rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js ('K') | « third_party/WebKit/Source/devtools/front_end/main/module.json ('k') | third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/OverlayModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js

diff --git a/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js b/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js

index 29c15334d34d6efcd4b89494f074b9091e74e371..40ed2d4c32143669c5d6680c74b26adac22d7a8c 100644

--- a/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js

+++ b/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js

@@ -40,7 +40,7 @@ ObjectUI.ObjectPopoverHelper = class {

dispose() {

if (this._resultHighlightedAsDOM)

- SDK.DOMModel.hideDOMNodeHighlight();

+ SDK.OverlayModel.hideDOMNodeHighlight();

if (this._linkifier)

this._linkifier.dispose();

}

@@ -131,7 +131,7 @@ ObjectUI.ObjectPopoverHelper = class {

var linkifier = null;

var resultHighlightedAsDOM = false;

if (result.subtype === 'node') {

- SDK.DOMModel.highlightObjectAsDOMNode(result);

+ SDK.OverlayModel.highlightObjectAsDOMNode(result);

resultHighlightedAsDOM = true;

}