[DeviceService] Replace content browser test with service test for BatteryMonitorImpl

[DeviceService] Replace content browser test with service test for BatteryMonitorImpl

This CL removes BatteryMonitorImpl content browser test, its renderer
side test is covered by existing battery layout tests, and its browser
side test is covered by the service test newly created in this CL.

Thus we can eliminate the direct dependency on battery from content
layer, then we can hide all battery monitor impl inside Device Service
with a follow-up CL.

BUG=684422
TEST=service_unittest
TBR=timvolodine@chromium.org

Review-Url: https://codereview.chromium.org/2819163002
Cr-Commit-Position: refs/heads/master@{#466833}
Committed: https://chromium.googlesource.com/chromium/src/+/b3592f9117184c7f54aeff8fcbe9d0d67ab11dc0

[leonhsl(Using Gerrit), 2017-04-17 02:20:18]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 02:20:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 02:23:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 02:23:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[leonhsl(Using Gerrit), 2017-04-17 02:41:57]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 02:42:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-04-17 03:05:37]

Patchset #1 (id:1) has been deleted

[leonhsl(Using Gerrit), 2017-04-17 03:10:08]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 03:10:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 04:01:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 04:01:16]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-04-17 05:07:18]

leon.han@intel.com changed reviewers:
+ blundell@chromium.org, rockot@chromium.org

[leonhsl(Using Gerrit), 2017-04-17 05:07:18]

PTAL, Thanks!

[blundell, 2017-04-18 13:25:10]

lgtm, thanks!

https://codereview.chromium.org/2819163002/diff/40001/content/browser/battery...
File content/browser/battery_status/battery_monitor_impl_browsertest.cc (left):

https://codereview.chromium.org/2819163002/diff/40001/content/browser/battery...
content/browser/battery_status/battery_monitor_impl_browsertest.cc:106:
GetTestUrl("battery_status", "battery_status_default_test.html");
Can we remove all these html files as part of this CL?

[leonhsl(Using Gerrit), 2017-04-19 02:44:44]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 02:45:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-04-19 02:45:29]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-04-19 02:48:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 02:48:32]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[leonhsl(Using Gerrit), 2017-04-19 02:54:01]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 02:54:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-04-19 03:20:07]

leon.han@intel.com changed reviewers:
+ timvolodine@chromium.org

[leonhsl(Using Gerrit), 2017-04-19 03:20:08]

Hi, Tim, would you PTAL for OWNER review of content/browser/battery_status/*?
Thanks!

https://codereview.chromium.org/2819163002/diff/40001/content/browser/battery...
File content/browser/battery_status/battery_monitor_impl_browsertest.cc (left):

https://codereview.chromium.org/2819163002/diff/40001/content/browser/battery...
content/browser/battery_status/battery_monitor_impl_browsertest.cc:106:
GetTestUrl("battery_status", "battery_status_default_test.html");
On 2017/04/18 13:25:10, blundell wrote:
> Can we remove all these html files as part of this CL?

I forgot this.. Done and thanks!

[commit-bot: I haz the power, 2017-04-19 03:51:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 03:51:54]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-04-21 08:46:54]

leon.han@intel.com changed reviewers:
+ kinuko@chromium.org

[leonhsl(Using Gerrit), 2017-04-21 08:46:55]

+kinuko@, would you please help to approve as //content OWNER? Seems Tim(battery
codes OWNER) is still OOO. Thanks!

[kinuko, 2017-04-21 09:06:21]

content lgtm

[leonhsl(Using Gerrit), 2017-04-24 11:53:27]

According the discussions at
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=f...
about how to handle these browser tests verifying features hosted by Device
Service, I'll land this CL now, then move forward to hide all battery impl
inside Device Service.

Once the new infra discussed there got ready, I'll create a new browser test to
do the simple end-2-end check for battery feature, together with all other
Device Service features.

Thanks all for review and let me TBR Tim for the trivial/testing only change in
device/battery/battery_status_service.cc, sending to CQ.

[leonhsl(Using Gerrit), 2017-04-24 11:54:17]

Description was changed from

==========
[DeviceService] Replace content browser test with service test for
BatteryMonitorImpl

This CL removes BatteryMonitorImpl content browser test, its renderer
side test is covered by existing battery layout tests, and its browser
side test is covered by the service test newly created in this CL.

Thus we can eliminate the direct dependency on battery from content
layer, then we can hide all battery monitor impl inside Device Service
with a follow-up CL.

BUG=684422
TEST=service_unittest
==========

to

==========
[DeviceService] Replace content browser test with service test for
BatteryMonitorImpl

This CL removes BatteryMonitorImpl content browser test, its renderer
side test is covered by existing battery layout tests, and its browser
side test is covered by the service test newly created in this CL.

Thus we can eliminate the direct dependency on battery from content
layer, then we can hide all battery monitor impl inside Device Service
with a follow-up CL.

BUG=684422
TEST=service_unittest
TBR=timvolodine@chromium.org
==========

[leonhsl(Using Gerrit), 2017-04-24 11:54:26]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2017-04-24 11:54:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2819163002/#ps80001
(title: "Rebase only")

[commit-bot: I haz the power, 2017-04-24 11:54:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 14:35:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 14:35:40]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[leonhsl(Using Gerrit), 2017-04-24 23:36:17]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2017-04-24 23:36:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 00:17:39]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493076977552330,
"parent_rev": "e33d2a5b01ecfcb5695bce2e1fa92d13c9b4265a", "commit_rev":
"b3592f9117184c7f54aeff8fcbe9d0d67ab11dc0"}

[commit-bot: I haz the power, 2017-04-25 00:18:49]

Description was changed from

==========
[DeviceService] Replace content browser test with service test for
BatteryMonitorImpl

This CL removes BatteryMonitorImpl content browser test, its renderer
side test is covered by existing battery layout tests, and its browser
side test is covered by the service test newly created in this CL.

Thus we can eliminate the direct dependency on battery from content
layer, then we can hide all battery monitor impl inside Device Service
with a follow-up CL.

BUG=684422
TEST=service_unittest
TBR=timvolodine@chromium.org
==========

to

==========
[DeviceService] Replace content browser test with service test for
BatteryMonitorImpl

This CL removes BatteryMonitorImpl content browser test, its renderer
side test is covered by existing battery layout tests, and its browser
side test is covered by the service test newly created in this CL.

Thus we can eliminate the direct dependency on battery from content
layer, then we can hide all battery monitor impl inside Device Service
with a follow-up CL.

BUG=684422
TEST=service_unittest
TBR=timvolodine@chromium.org

Review-Url: https://codereview.chromium.org/2819163002
Cr-Commit-Position: refs/heads/master@{#466833}
Committed:
https://chromium.googlesource.com/chromium/src/+/b3592f9117184c7f54aeff8fcbe9...
==========

[commit-bot: I haz the power, 2017-04-25 00:18:52]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/b3592f9117184c7f54aeff8fcbe9...