Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2819053002: MD Settings: Make disabled CrSettingsLanguagesTest.Languages succeed locally. (Closed)

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
dschuyler
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Make disabled CrSettingsLanguagesTest.Languages succeed locally. This is the 1st step of deflaking and eventually re-enabling those tests. Since they have been fully disabled for a while, the change made at https://codereview.chromium.org/2779873003 (after the tests were disabled), causes the tests to always fail (<settings-languages> initialization moved from created() to attached()). This CL does not re-enable those tests, because there is more work to get there (for example using a test browser proxy) BUG=692356 Review-Url: https://codereview.chromium.org/2819053002 Cr-Commit-Position: refs/heads/master@{#464846} Committed: https://chromium.googlesource.com/chromium/src/+/bc1c102b111b5107384ff8a2cbf806870966a49c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/test/data/webui/settings/languages_tests.js View 2 chunks +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
dpapad
3 years, 8 months ago (2017-04-14 23:38:18 UTC) #7
dschuyler
lgtm
3 years, 8 months ago (2017-04-15 01:32:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819053002/1
3 years, 8 months ago (2017-04-15 01:38:09 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-15 01:42:39 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc1c102b111b5107384ff8a2cbf8...

Powered by Google App Engine
This is Rietveld 408576698