Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2819011: TTF: Reenable some disabled tests. (Closed)

Created:
10 years, 6 months ago by vandebo (ex-Chrome)
Modified:
9 years, 7 months ago
Reviewers:
eroman, James Hawkins
CC:
chromium-reviews, ncarter (slow), idana, ben+cc_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., tim (not reviewing)
Visibility:
Public.

Description

TTF: Reenable some disabled tests. DevToolsSanityTest.TestConsoleLog seems to work ProxyResolverV8Test.FAILS_ReturnUnicode DepTest.FAILS_TestDepDisable VectorCanvasTest.FAILS_Matrix TEST=none BUG=disabled tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50258

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/debugger/devtools_sanity_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_resolver_v8_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M sandbox/src/dep_test.cc View 1 chunk +2 lines, -2 lines 1 comment Download
M skia/ext/vector_canvas_unittest.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
vandebo (ex-Chrome)
10 years, 6 months ago (2010-06-18 00:31:08 UTC) #1
James Hawkins
http://codereview.chromium.org/2819011/diff/1/5 File sandbox/src/dep_test.cc (right): http://codereview.chromium.org/2819011/diff/1/5#newcode169 sandbox/src/dep_test.cc:169: // This test fails. See bug 1275842 Should we ...
10 years, 6 months ago (2010-06-18 00:32:38 UTC) #2
eroman
10 years, 6 months ago (2010-06-18 00:37:52 UTC) #3
lgtm for the net change.

Powered by Google App Engine
This is Rietveld 408576698